Support hot cold splitting in crossgen2 #74963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshung
added
NO-MERGE
cshung
force-pushed
the
public/hot-cold-splitting-crossgen2
branch
from
52ed3c2
to
05be8ec
Compare
cshung
force-pushed
the
public/hot-cold-splitting-crossgen2
branch
from
e186ef0
to
bdbab66
Compare
cshung
force-pushed
the
public/hot-cold-splitting-crossgen2
branch
2 times, most recently
from
4ba78a9
to
324b616
Compare
This was referenced Oct 13, 2022
trylek
reviewed
Oct 19, 2022
...r/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/MethodGCInfoNode.cs
Outdated
Show resolved
Hide resolved
trylek
reviewed
Oct 19, 2022
...r/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/MethodGCInfoNode.cs
Outdated
Show resolved
Hide resolved
trylek
reviewed
Oct 19, 2022
...r/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/MethodGCInfoNode.cs
Outdated
Show resolved
Hide resolved
trylek
reviewed
Oct 19, 2022
...r/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/MethodWithGCInfo.cs
Show resolved
Hide resolved
trylek
reviewed
Oct 19, 2022
...r/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/MethodWithGCInfo.cs
Outdated
Show resolved
Hide resolved
trylek
reviewed
Oct 19, 2022
...ot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/RuntimeFunctionsTableNode.cs
Outdated
Show resolved
Hide resolved
trylek
reviewed
Oct 19, 2022
...ot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/RuntimeFunctionsTableNode.cs
Outdated
Show resolved
Hide resolved
trylek
reviewed
Oct 19, 2022
...ot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/RuntimeFunctionsTableNode.cs
Outdated
Show resolved
Hide resolved
trylek
reviewed
Oct 19, 2022
src/coreclr/tools/aot/ILCompiler.ReadyToRun/JitInterface/CorInfoImpl.ReadyToRun.cs
Outdated
Show resolved
Hide resolved
trylek
reviewed
Oct 19, 2022
src/coreclr/tools/aot/ILCompiler.ReadyToRun/JitInterface/CorInfoImpl.ReadyToRun.cs
Outdated
Show resolved
Hide resolved
trylek
reviewed
Oct 19, 2022
src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/Amd64/UnwindInfo.cs
Show resolved
Hide resolved
trylek
reviewed
Oct 19, 2022
src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ReadyToRunMethod.cs
Outdated
Show resolved
Hide resolved
trylek
reviewed
Oct 19, 2022
src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ReadyToRunReader.cs
Outdated
Show resolved
Hide resolved
trylek
reviewed
Oct 19, 2022
src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ReadyToRunReader.cs
Show resolved
Hide resolved
trylek
reviewed
Oct 19, 2022
src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ReadyToRunReader.cs
Show resolved
Hide resolved
trylek
reviewed
Oct 19, 2022
src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ReadyToRunReader.cs
Show resolved
Hide resolved
trylek
reviewed
Oct 19, 2022
src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ReadyToRunReader.cs
Show resolved
Hide resolved
trylek
reviewed
Oct 19, 2022
trylek
reviewed
Oct 19, 2022
trylek
reviewed
Oct 19, 2022
trylek
reviewed
Oct 19, 2022
trylek
reviewed
Oct 19, 2022
trylek
reviewed
Oct 19, 2022
trylek
reviewed
Oct 19, 2022
trylek
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
Thanks Andrew, I believe you, Aman and Eugenio have done a great job, overall this looks great to me, I haven't noticed any blocking issues, I have shared a couple of suggestions for local code cleanups and deduplications and I have a few questions regarding bits of code I have a hard time to comprehend but that's about it.
trylek
reviewed
Oct 19, 2022
|
Please also note that there are some conflicts you'll need to resolve. For lab testing, I suppose we should probably tweak the Crossgen2 pipelines to use the hot-cold code splitting and run the crossgen2 outerloop pipeline with this change. |
|
I should probably also emphasize that I mostly focused on Crossgen2 and runtime parts of the change, while I think I've been able to mostly follow the intent of the JIT changes, these definitely merit reviewing by a better JIT expert than me. |
cshung
force-pushed
the
public/hot-cold-splitting-crossgen2
branch
from
324b616
to
7598273
Compare
...r/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/MethodWithGCInfo.cs
Outdated
Show resolved
Hide resolved
...r/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/MethodWithGCInfo.cs
Outdated
Show resolved
Hide resolved
...r/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/MethodWithGCInfo.cs
Outdated
Show resolved
Hide resolved
...r/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/MethodWithGCInfo.cs
Outdated
Show resolved
Hide resolved
...r/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/MethodWithGCInfo.cs
Outdated
Show resolved
Hide resolved
...r/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/MethodWithGCInfo.cs
Outdated
Show resolved
Hide resolved
...r/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/MethodWithGCInfo.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Aman Khalid <58230338+amanasifkhalid@users.noreply.github.com> Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com>
cshung
force-pushed
the
public/hot-cold-splitting-crossgen2
branch
from
3a5aed2
to
f17547b
Compare
cshung
changed the title
cshung
removed
the
NO-MERGE
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR created by merging the code from the feature branch on runtimelab.
@amanasifkhalid
@EugenioPena
@dotnet/crossgen-contrib