Ensure Microsoft.Interop.SourceGeneration ships

[ericstj]

Fixes: #74944

Also fix the LibraryImportGenerator and JSImportGenerator to package Microsoft.Interop.SourceGeneration correctly (should IsPackable ever be set).

[ghost]

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Also fix the LibraryImportGenerator and JSImportGenerator to package Microsoft.Interop.SourceGeneration correctly (should IsPackable ever be set).

Author:	ericstj
Assignees:	ericstj
Labels:	area-System.Runtime.InteropServices
Milestone:	-

[radical]

/azp run runtime-wasm

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ericstj]

@AaronRobinsonMSFT - as part of attempting to remove the packaging, I noticed that the package redistributed https://github.com/dotnet/runtime/blob/main/src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Microsoft.Interop.LibraryImportGenerator.props. I see we import this in runtime targets. What's the story for end-customers consuming the inbox generator? I didn't see those items added by the SDK targets anywhere: https://github.com/search?q=org%3Adotnet+LibraryImportGenerator_UseMarshalType&type=code

[AaronRobinsonMSFT]

@AaronRobinsonMSFT - as part of attempting to remove the packaging, I noticed that the package redistributed https://github.com/dotnet/runtime/blob/main/src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Microsoft.Interop.LibraryImportGenerator.props. I see we import this in runtime targets. What's the story for end-customers consuming the inbox generator? I didn't see those items added by the SDK targets anywhere: https://github.com/search?q=org%3Adotnet+LibraryImportGenerator_UseMarshalType&type=code

@ericstj At present, this is only for our own internal testing and develop needs. No user should ever need these settings. It is possible we will add some in the future but we can handle that when it becomes a user configuration.

[akoeplinger]

/azp run runtime-wasm

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[radical]

/azp run runtime-wasm-perf

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[lewing]

Feel free to merge before the wasm tests finish

[ericstj]

Libraries failures are #74952.

@radical - I'm inclined to merge this ASAP since the source interop generators are broken and this will fix it. What coverage are you looking for from those legs? Do you want to wait on them?

[ericstj]

Thanks @lewing. I'll be online today - if anyone is seeing more fallout from this or the previous change, please ping me on teams and I'll take a look right away.