-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0] Disable copying ProjectReferences in generator projects #74921
Conversation
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsBackport of #74897 to release/7.0-rc1 /cc @ViktorHofer @ericstj Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
@danmoseley FYI. This is a necessary change to build successfully without double file writes. See #74897 (comment). |
This should target release/7.0 directly. I think rc1 does not have runway anymore. Unless @mmitche says otherwise. |
A coherent build was already generated for rc1 on Tuesday. We can keep merging PRs into the rc1 branch and they will keep flowing to release/7.0 via the bot, but it's an unnecesary step when we are not going to keep generating builds out of that branch unless something customer-facing is terribly broken. |
Just changed the base branch to release/7.0. |
Thanks. I was expecting the total number of modified files to get reduced now that they are doing the diff against the 7.0 branchm, which already has the pool modifications. Unless I'm missing something? Do you know why those files are still showing up? |
Unsure. But let's close this PR as the original one is incomplete and needs a follow-up change. |
Backport of #74897 to release/7.0
/cc @ViktorHofer @ericstj
Customer Impact
Testing
Risk
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.