Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Disable copying ProjectReferences in generator projects #74921

Closed

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 1, 2022

Backport of #74897 to release/7.0

/cc @ViktorHofer @ericstj

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Sep 1, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #74897 to release/7.0-rc1

/cc @ViktorHofer @ericstj

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@ViktorHofer
Copy link
Member

@danmoseley FYI. This is a necessary change to build successfully without double file writes. See #74897 (comment).

@carlossanlop
Copy link
Member

This should target release/7.0 directly. I think rc1 does not have runway anymore. Unless @mmitche says otherwise.

@ViktorHofer
Copy link
Member

ViktorHofer commented Sep 1, 2022

We just today merged a change into 7.0-rc1: #74906. @mmitche can you please clarify.

@carlossanlop
Copy link
Member

carlossanlop commented Sep 1, 2022

A coherent build was already generated for rc1 on Tuesday. We can keep merging PRs into the rc1 branch and they will keep flowing to release/7.0 via the bot, but it's an unnecesary step when we are not going to keep generating builds out of that branch unless something customer-facing is terribly broken.

@ViktorHofer ViktorHofer changed the base branch from release/7.0-rc1 to release/7.0 September 1, 2022 15:43
@ViktorHofer ViktorHofer changed the title [release/7.0-rc1] Disable copying ProjectReferences in generator projects [release/7.0] Disable copying ProjectReferences in generator projects Sep 1, 2022
@ViktorHofer
Copy link
Member

Just changed the base branch to release/7.0.

@carlossanlop
Copy link
Member

Just changed the base branch to release/7.0.

Thanks. I was expecting the total number of modified files to get reduced now that they are doing the diff against the 7.0 branchm, which already has the pool modifications. Unless I'm missing something? Do you know why those files are still showing up?

@ViktorHofer
Copy link
Member

ViktorHofer commented Sep 1, 2022

Unsure. But let's close this PR as the original one is incomplete and needs a follow-up change.

@ViktorHofer ViktorHofer closed this Sep 1, 2022
@ViktorHofer ViktorHofer deleted the backport/pr-74897-to-release/7.0-rc1 branch September 1, 2022 16:54
@ghost ghost locked as resolved and limited conversation to collaborators Oct 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants