Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0-rc1] Revert "[MONO] Move marshal-ilgen into a component (#71203)" #74675

Merged

Conversation

lambdageek
Copy link
Member

This reverts commit de32c44.

@lambdageek
Copy link
Member Author

The corresponding revert for main is #74674

@lewing
Copy link
Member

lewing commented Aug 26, 2022

is this going to break any of the static web assets in the sdk? someone will need to keep an eye on that if this flows

Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if it is green

@lambdageek
Copy link
Member Author

is this going to break any of the static web assets in the sdk? someone will need to keep an eye on that if this flows

I don't see any mention of marshal-ilgen (or marshal_ilgen) elsewhere in the dotnet org (and in particular not in dotnet/sdk) so I think... probably not?

https://cs.github.com/?scopeName=All+repos&scope=&q=org%3Adotnet+%28marshal-ilgen+OR+marshal_ilgen%29

the componentization stuff produces only .a files for wasm. so they wouldn't show up in, for example, blazor's app bundle tests

@carlossanlop
Copy link
Member

CI is green. Ready to merge.

@carlossanlop carlossanlop merged commit 06aceb7 into dotnet:release/7.0-rc1 Aug 27, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants