Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0-rc1] [wasm] Unwrap exception when calling entrypoint #74263

Merged
merged 2 commits into from
Aug 20, 2022

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #74235 to release/7.0-rc1

/cc @lewing @maraf

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. please get a code review and once we have a green ci we can merge.

@carlossanlop
Copy link
Member

@lewing @maraf @radical there are many CI failures. Is any of them related to this change?

@maraf
Copy link
Member

maraf commented Aug 20, 2022

No. We saw it on other builds when msbuild (according to the binlog) says it succeeded, but dotnet cli exits with code 1.

@carlossanlop
Copy link
Member

Approved and signed off.
CI failures determined to be unrelated.
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit b3ef656 into release/7.0-rc1 Aug 20, 2022
@carlossanlop carlossanlop deleted the backport/pr-74235-to-release/7.0-rc1 branch August 20, 2022 21:12
@ghost ghost locked as resolved and limited conversation to collaborators Sep 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants