Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Xunit to 2.4.2 #74262

Merged
merged 1 commit into from
Aug 20, 2022
Merged

Update Xunit to 2.4.2 #74262

merged 1 commit into from
Aug 20, 2022

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Aug 19, 2022

No description provided.

@ghost
Copy link

ghost commented Aug 19, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: ericstj
Assignees: ericstj
Labels:

area-Infrastructure-libraries

Milestone: -

@ViktorHofer
Copy link
Member

This currently blocks the test stabilization exercise. I reran the failing legs and will merge this as soon as I'm confident that eventual remaining failures are unrelated. Also I will need to cherry-pick this commit into the 7.0.0-test branch.

@ViktorHofer ViktorHofer merged commit 6d60d06 into dotnet:main Aug 20, 2022
@ViktorHofer
Copy link
Member

/backport to release/7.0-rc1

@github-actions
Copy link
Contributor

Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2895365634

ViktorHofer pushed a commit that referenced this pull request Aug 20, 2022
@github-actions
Copy link
Contributor

@ViktorHofer backporting to release/7.0-rc1 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Update Xunit to 2.4.2
Using index info to reconstruct a base tree...
M	eng/Versions.props
Falling back to patching base and 3-way merge...
Auto-merging eng/Versions.props
CONFLICT (content): Merge conflict in eng/Versions.props
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update Xunit to 2.4.2
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

ViktorHofer added a commit that referenced this pull request Aug 20, 2022
2.4.2 stable released ~2 weeks ago and we have at least one shipping library that depends on it. For releasing 7.0.0, we must not depend on prerelease versions.

Manual backport of #74262
@ViktorHofer
Copy link
Member

#74296

carlossanlop pushed a commit that referenced this pull request Aug 21, 2022
2.4.2 stable released ~2 weeks ago and we have at least one shipping library that depends on it. For releasing 7.0.0, we must not depend on prerelease versions.

Manual backport of #74262
@ghost ghost locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants