[release/7.0-rc1] Add a way to suppress all trimming warnings #74220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://github.com/avatars/in/15368?s=60&v=4){kind=small}
Fixes #73926. Also adding AOT analysis suppression for parity. I didn't port the warning level support because the compat kind of goes beyond that. We can revisit later if needed.
MichalStrehovsky
approved these changes
Aug 19, 2022
jeffschwMSFT
approved these changes
Aug 19, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #74137 to release/7.0-rc1
/cc @MichalStrehovsky
Customer Impact
SuppressTrimAnalysisWarnings MSBuild setting doesn't suppress trimming warnings.
This was a change made in the linker repo that landed too late in the runtime repo to do something about before the RC1 cutoff: dotnet/linker#2930.
Testing
We exercise trimming warning suppression within the repo. It was a build break when the IL Linker change landed. We no longer need the build break workaround. Also tested manually.
Risk
This affects warning infrastructure. I've manually validated warnings still show up when not suppressed E2E.