-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update assembly version from hardcoded to MajorVersion #74157
Commits on Oct 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b985a5d - Browse repository at this point
Copy the full SHA b985a5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 371465c - Browse repository at this point
Copy the full SHA 371465cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ef101c - Browse repository at this point
Copy the full SHA 6ef101cView commit details -
Retrieve major version dynamically for expected message in SurrogateP…
…rovider_MemberData
Configuration menu - View commit details
-
Copy full SHA for 0780ab4 - Browse repository at this point
Copy the full SHA 0780ab4View commit details -
Manually generate the TestData.resources.
The dotnet exec command generated by the msbuild Target had to be manually executed in the cmdline with the target framework folders for RemoteExecutor hardcoded to net7.0-windows so the resources file could be generated.
Configuration menu - View commit details
-
Copy full SHA for b27254a - Browse repository at this point
Copy the full SHA b27254aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 727f422 - Browse repository at this point
Copy the full SHA 727f422View commit details
Commits on Oct 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 2ae65a5 - Browse repository at this point
Copy the full SHA 2ae65a5View commit details
Commits on Nov 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for cefdcea - Browse repository at this point
Copy the full SHA cefdceaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4040569 - Browse repository at this point
Copy the full SHA 4040569View commit details -
Configuration menu - View commit details
-
Copy full SHA for c906e67 - Browse repository at this point
Copy the full SHA c906e67View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7085bbf - Browse repository at this point
Copy the full SHA 7085bbfView commit details -
Retrieve major version dynamically for expected message in SurrogateP…
…rovider_MemberData
Configuration menu - View commit details
-
Copy full SHA for 72a9121 - Browse repository at this point
Copy the full SHA 72a9121View commit details -
Manually generate the TestData.resources.
The dotnet exec command generated by the msbuild Target had to be manually executed in the cmdline with the target framework folders for RemoteExecutor hardcoded to net7.0-windows so the resources file could be generated.
Configuration menu - View commit details
-
Copy full SHA for 9b7515e - Browse repository at this point
Copy the full SHA 9b7515eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 38ef5be - Browse repository at this point
Copy the full SHA 38ef5beView commit details -
Configuration menu - View commit details
-
Copy full SHA for d760fa5 - Browse repository at this point
Copy the full SHA d760fa5View commit details -
Extract the LocalEchoServer bits from the projects
.. so that the helix bits are in a LocalEchoServer.helix.targets , instead of being special-cased in sendtohelix-wasm.targets . - And this is setup and used by the test projects by importing one file.
Configuration menu - View commit details
-
Copy full SHA for d3bfb56 - Browse repository at this point
Copy the full SHA d3bfb56View commit details -
Build the LocalEchoServers specifically without using artifacts .
- The RemoteLoopServer, and NetCoreServer are projects used as aspnetcore middleware, and loaded by xharness. - These are built against the live artifacts, same as other projects. - But this can be a problem when the libraries in `runtime` are on a newer assembly version (say `8.0.0`), but xharness is still built with `7.0.0` libraries. - In that case, xharness fails to load the middleware: ``` Application startup exception: System.Reflection.ReflectionTypeLoadException: Unable to load one or more of the requested types. ... Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified. at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module) at System.Reflection.Assembly.GetTypes() at Microsoft.DotNet.XHarness.CLI.CommandArguments.TypeFromAssemblyArgument`1.GetLoadedTypes()+MoveNext() in /_/src/Microsoft.DotNet.XHarness.CLI/CommandArguments/Arguments/TypeFromAssemblyArgument.cs:line 29 at Microsoft.DotNet.XHarness.CLI.Commands.WebServer.<>c__DisplayClass0_0.<Start>b__9(TestWebServerOptions options) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/WebServer.cs:line 60 at Microsoft.Extensions.Options.OptionsFactory`1.Create(String name) at Microsoft.Extensions.Options.OptionsCache`1.<>c__3`1.<GetOrAdd>b__3_0(String name, ValueTuple`2 arg) at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd[TArg](TKey key, Func`3 valueFactory, TArg factoryArgument) at Microsoft.Extensions.Options.OptionsCache`1.GetOrAdd[TArg](String name, Func`3 createOptions, TArg factoryArgument) at Microsoft.DotNet.XHarness.CLI.Commands.WebServer.TestWebServerStartup.Configure(IApplicationBuilder app, IOptionsMonitor`1 optionsAccessor) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/WebServer.cs:line 126 at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor) at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr) at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) at Microsoft.AspNetCore.Hosting.ConfigureBuilder.Invoke(Object instance, IApplicationBuilder builder) at Microsoft.AspNetCore.Hosting.ConventionBasedStartup.Configure(IApplicationBuilder app) at Microsoft.AspNetCore.Hosting.WebHost.BuildApplication() ``` - Build the project in isolation from rest of the repo, so that it is built with references only from the SDK. The built assembly can then be deployed for use with xharness, just like before.
Configuration menu - View commit details
-
Copy full SHA for 63fe2dc - Browse repository at this point
Copy the full SHA 63fe2dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ba793c - Browse repository at this point
Copy the full SHA 0ba793cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8199b4b - Browse repository at this point
Copy the full SHA 8199b4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad3c98a - Browse repository at this point
Copy the full SHA ad3c98aView commit details -
[wasm] Avoid duplicate imports, and don't use the targetingpacks.targets
.. for runtime tests since the paths are set explicitly in the project
Configuration menu - View commit details
-
Copy full SHA for 5651091 - Browse repository at this point
Copy the full SHA 5651091View commit details -
[wasm] Workaround for dotnet#77707
The middleware projects are now being built separately, so they can target a different TFM. But when `RunAOTCompilation=true` is set, like on CI/AOT builds, the build breaks with: ``` To build this project, the following workloads must be installed: macos [/__w/1/s/Build.proj] To install these workloads, run the following command: dotnet workload restore [/__w/1/s/Build.proj] ``` This is described in dotnet#77707 . And the issue is present in `7.0 rc1` also, which is currently used for building the repo. To workaround it, we unset some properties which aren't needed anyway for the middleware projects builds.
Configuration menu - View commit details
-
Copy full SHA for fcc492e - Browse repository at this point
Copy the full SHA fcc492eView commit details -
Merge branch 'Net8Changes' of https://github.com/carlossanlop/runtime …
…into Net8Changes
Configuration menu - View commit details
-
Copy full SHA for 889650f - Browse repository at this point
Copy the full SHA 889650fView commit details