Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize GetExactClasses in repGetExactClasses #74156

Closed
wants to merge 1 commit into from

Conversation

kunalspathak
Copy link
Member

@kunalspathak kunalspathak commented Aug 18, 2022

superpmi-replay is still failing with AV. Initialize GetExactClass at one more place.

@kunalspathak
Copy link
Member Author

@dotnet/jit-contrib

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 18, 2022
@ghost ghost assigned kunalspathak Aug 18, 2022
@ghost
Copy link

ghost commented Aug 18, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: kunalspathak
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@EgorBo
Copy link
Member

EgorBo commented Aug 18, 2022

I don't think it's needed after #74095 was merged

if the list is null then AssertMapAndKeyExist will just report it as a missing context

@kunalspathak
Copy link
Member Author

Ok. I see what Bruce meant when he pointed that PR our. Basically, even if we initialize, it will anyway won't find key.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants