Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuperPMI collection fix by instantiating 'GetExactClasses' if it is null #74037

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

TIHan
Copy link
Contributor

@TIHan TIHan commented Aug 17, 2022

SuperPMI collections have been failing since yesterday. Upon investigation, I was able to reproduce the issue simply by trying to SuperPMI collect a hello world app.

There was a null variable, GetExactClasses, trying to be accessed. It was added in #64497. The fix is to initialize this variable if it is null. Looking at similar variables like this, the same logic exists, for example:

    if (GetArgType == nullptr)
        GetArgType = new LightWeightMap<Agnostic_GetArgType_Key, Agnostic_GetArgType_Value>();

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 17, 2022
@ghost ghost assigned TIHan Aug 17, 2022
@ghost
Copy link

ghost commented Aug 17, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

SuperPMI collections have been failing since yesterday. Upon investigation, I was able to reproduce the issue simply by trying to SuperPMI collect a hello world app.

There was a null variable, GetExactClasses, trying to be accessed. It was added in #64497. The fix is to initialize this variable if it is null. Looking at similar variables like this, the same logic exists, for example:

    if (GetArgType == nullptr)
        GetArgType = new LightWeightMap<Agnostic_GetArgType_Key, Agnostic_GetArgType_Value>();
Author: TIHan
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@jakobbotsch
Copy link
Member

I think repGetExactClasses is also missing an AssertMapAndKeyExist.

@JulieLeeMSFT JulieLeeMSFT added this to the 8.0.0 milestone Aug 17, 2022
@AndyAyersMS
Copy link
Member

Would be nice to get this fixed soon.

@TIHan TIHan merged commit 69e7178 into dotnet:main Aug 17, 2022
@kunalspathak
Copy link
Member

I think repGetExactClasses is also missing an AssertMapAndKeyExist.

I am seeing this failing in superpmi-replay. I will send out a PR shortly.

@BruceForstall
Copy link
Member

I think repGetExactClasses is also missing an AssertMapAndKeyExist.

I am seeing this failing in superpmi-replay. I will send out a PR shortly.

Note: #74095

@kunalspathak
Copy link
Member

Note: #74095

What about it?

I will send out a PR shortly.

#74156

@ghost ghost locked as resolved and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants