Publish ILC as a trimmed+R2R+singlefile executable #73987
Conversation
This is the same configuration that we ship crossgen2 with. It produces a lot smaller packages with faster startup time. Setting this as `CoreCLRILCompilerDir` ensures that this is the ILCompiler that we test, build crossgen2 with, and package. I don't have high confidence that we can get dotnet#67742 in time for .NET 7 but since we still have some runway before .NET 7 snaps, checking this in as a plan B. This change is temporary until dotnet#67742 is fixed.
ghost
assigned 
MichalStrehovsky
added
area-NativeAOT-coreclr
and removed
area-crossgen2-coreclr
labels
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| <PublishSingleFile>true</PublishSingleFile> | ||
| </PropertyGroup> | ||
|
|
||
| <Target Name="PublishCompiler" |
There was a problem hiding this comment.
Is the publish going to use live-built runtime or the LKG runtime from https://github.com/dotnet/runtime/blob/main/global.json ?
If it is the later, is this going to have fallout for servicing and source build?
There was a problem hiding this comment.
It's using the LKG.
We update the LKG as part of servicing, so the expectation is that we'll ship this on top of RC1 (like we did .NET 6), and upgrade to RTM for the next servicing release (we'll be always a build behind).
There was a problem hiding this comment.
But yes, this would definitely be an issue for source build and doing #67742 would be a ship blocker then. I have another email thread on the fate of source build. People above my paygrade need to make decisions on what to keep in 7.0.
|
I went through all the failures in the relevant pipelines - all tests are passing per the console logs. But if something was broken by this, we wouldn't get to running tests in the first place. |
@MichalStrehovsky @jkotas just so you know, this change will go into RC1 since we had to delay the snap for a full day. Considering your comment quoted above, please make sure to submit a backport of the actual fix to RC1 or later to RC2. |
This is the same configuration that we ship crossgen2 with on platforms that don't have NativeAOT. It produces a lot smaller packages with faster startup time. Setting this as
CoreCLRILCompilerDirensures that this is the ILCompiler that we test, build crossgen2 with, and package.I don't have high confidence that we can get #67742 in time for .NET 7 but since we still have some runway before .NET 7 snaps, proposing checking this in as a plan B.
This change would be temporary until #67742 is fixed.
Cc @dotnet/ilc-contrib