[mono] Don't truncate the high bits when ldelema index is nint #73799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdageek
approved these changes
Aug 11, 2022
lambdageek
reviewed
Aug 11, 2022
BrzVlad
force-pushed
the
fix-array-index-nint
branch
from
815cadb
to
6affcd2
Compare
BrzVlad
force-pushed
the
fix-array-index-nint
branch
from
6affcd2
to
106d85a
Compare
We previously assumend index is i32, but it can be either i32 or native int. In order to avoid code bloat by adding native int versions to all opcodes (LDELEM, STELEM and LDELEMA) for negligible perf gain, just add one additional data to these instructions which indicates whether to fetch the index var as a i32 or native int. On interp we don't zero extend by default to 8 byte when storing into locals (we should probably do this at some point), so we need to special handle nint argument.
Remove MONO_ARCH_EMIT_BOUNDS_CHECK on amd64 since it was doing a I4 comparison, while the index reg is i8. Use MONO_EMIT_DEFAULT_BOUNDS_CHECK instead also on amd64.
BrzVlad
force-pushed
the
fix-array-index-nint
branch
from
106d85a
to
a99b578
Compare
|
I'll consider a better way to fix this |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71656