Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage the shipping, roslyn based ApiCompat in dotnet/runtime #73263

Merged

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Aug 2, 2022

@smasher164 and I'll be working on this over the next weeks.

Progress

Library Preserve Comments Use Global Suppressions Review Suppressions
coreclr/CoreLib
nativeaot/CoreLib
Microsoft.Extensions.DependencyInjection.Specification.Tests
Microsoft.Win32.SystemEvents n/a n/a
Microsoft.VisualBasic.Core n/a
System.CodeDom n/a n/a
System.Collections.Specialized
System.Collections n/a
System.Configuration.ConfigurationManager
System.Data.Odbc
System.Data.OleDb n/a n/a
System.Diagnostics.Debug n/a
System.Diagnostics.EventLog n/a n/a
System.Diagnostics.PerformanceCounter n/a n/a
System.Diagnostics.Tracing
System.Drawing.Common n/a n/a
System.IO.Compression
System.IO.Pipes
System.Linq.Expressions n/a
System.Linq
System.Net.Primitives
System.Net.Security
System.Reflection.Context
System.Runtime.InteropServices.JavaScript n/a n/a n/a
System.Runtime.InteropServices n/a n/a
System.Runtime.Serialization.Formatters
System.Runtime
System.Security.Cryptography.Pkcs
System.Security.Cryptography.Xml
System.Security.Permissions
System.ServiceModel.Syndication
System.Threading.Thread
System.Threading.ThreadPool n/a
System.Xml.ReaderWriter
ApiCompatBaseline.NetCoreAppLatestStable
ApiCompatBaseline.netstandard2.0
ApiCompatBaseline.netstandard2.1
mono/CoreLib

@ViktorHofer ViktorHofer added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 2, 2022
@ghost
Copy link

ghost commented Aug 2, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: ViktorHofer
Assignees: ViktorHofer, smasher164
Labels:

NO-MERGE, area-Infrastructure-libraries

Milestone: -

@ViktorHofer ViktorHofer changed the title [WIP] Consume ApiCompat's ValidateAssemblies task [No Review, WIP] Consume ApiCompat's ValidateAssemblies task Aug 3, 2022
@ViktorHofer ViktorHofer added NO-REVIEW Experimental/testing PR, do NOT review it and removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) labels Aug 3, 2022
@smasher164 smasher164 force-pushed the ConsumeApiCompatValidateAssembliesTask branch from c27da0c to 0c700c5 Compare August 29, 2022 21:35
@ViktorHofer
Copy link
Member Author

The emitted compatibility difference for System.ValueTuple was useful. Fixing this via #74817.

@ViktorHofer ViktorHofer marked this pull request as ready for review October 13, 2022 11:09
@ViktorHofer ViktorHofer changed the title [No Review, WIP] Consume ApiCompat's ValidateAssemblies task Leverage the shipping, roslyn based ApiCompat in dotnet/runtime Oct 13, 2022
@ViktorHofer ViktorHofer removed the NO-REVIEW Experimental/testing PR, do NOT review it label Oct 13, 2022
@ViktorHofer
Copy link
Member Author

The remaining failure seems to be an actual build issue that needs investigation. Let's not merge the PR until that is sorted out.

@ViktorHofer ViktorHofer merged commit 960e4d7 into dotnet:main Oct 16, 2022
@ViktorHofer ViktorHofer deleted the ConsumeApiCompatValidateAssembliesTask branch October 16, 2022 13:15
@ghost ghost locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants