-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leverage the shipping, roslyn based ApiCompat in dotnet/runtime #73263
Merged
ViktorHofer
merged 53 commits into
dotnet:main
from
ViktorHofer:ConsumeApiCompatValidateAssembliesTask
Oct 16, 2022
Merged
Leverage the shipping, roslyn based ApiCompat in dotnet/runtime #73263
ViktorHofer
merged 53 commits into
dotnet:main
from
ViktorHofer:ConsumeApiCompatValidateAssembliesTask
Oct 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
added
the
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
label
Aug 2, 2022
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue Detailsnull
|
ViktorHofer
changed the title
[WIP] Consume ApiCompat's ValidateAssemblies task
[No Review, WIP] Consume ApiCompat's ValidateAssemblies task
Aug 3, 2022
ViktorHofer
added
NO-REVIEW
Experimental/testing PR, do NOT review it
and removed
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
labels
Aug 3, 2022
ViktorHofer
commented
Aug 25, 2022
src/libraries/Microsoft.Extensions.Hosting/src/CompatibilitySuppressions.xml
Outdated
Show resolved
Hide resolved
smasher164
force-pushed
the
ConsumeApiCompatValidateAssembliesTask
branch
from
August 29, 2022 21:35
c27da0c
to
0c700c5
Compare
The emitted compatibility difference for System.ValueTuple was useful. Fixing this via #74817. |
ViktorHofer
commented
Aug 31, 2022
src/libraries/System.DirectoryServices/src/CompatibilitySuppressions.xml
Outdated
Show resolved
Hide resolved
This was referenced Oct 12, 2022
ViktorHofer
requested review from
lewing,
pavelsavara,
marek-safar and
MichalStrehovsky
as code owners
October 13, 2022 11:09
ViktorHofer
changed the title
[No Review, WIP] Consume ApiCompat's ValidateAssemblies task
Leverage the shipping, roslyn based ApiCompat in dotnet/runtime
Oct 13, 2022
smasher164
approved these changes
Oct 14, 2022
The remaining failure seems to be an actual build issue that needs investigation. Let's not merge the PR until that is sorted out. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@smasher164 and I'll be working on this over the next weeks.
Progress