Enable AOT analyzer in System.Net.HttpListener and System.Net.Http.Json #73191
Conversation
Refactor code in System.Net.HttpListener to be AOT safe Add annotations to System.Net.Http.Json to mark API as unsafe for AOT
tlakollo
requested review from
jkotas,
LakshanF,
vitek-karas and
MichalStrehovsky
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
src/libraries/System.Net.Http.Json/src/System/Net/Http/Json/HttpContentJsonExtensions.cs
Outdated
Show resolved
Hide resolved
| @@ -132,7 +132,7 @@ internal void SetServerTimeout(int[] timeouts, uint minSendBytesPerSecond) | |||
|
|
|||
| SetUrlGroupProperty( | |||
| Interop.HttpApi.HTTP_SERVER_PROPERTY.HttpServerTimeoutsProperty, | |||
| infoptr, (uint)Marshal.SizeOf(typeof(Interop.HttpApi.HTTP_TIMEOUT_LIMIT_INFO))); | |||
| infoptr, (uint)Marshal.SizeOf<Interop.HttpApi.HTTP_TIMEOUT_LIMIT_INFO>()); | |||
There was a problem hiding this comment.
These are blittable structs and they are passed in into the PInvoke without any marshalling. It would be better to replace this with sizeof(Interop.HttpApi.HTTP_TIMEOUT_LIMIT_INFO). Similar in other places
There was a problem hiding this comment.
While you are on it - could you please also delete infoptr local, pass &timeoutinfo directly to the HttpServerTimeoutsProperty method, and replace IntPtr with void* in the implementation of the HttpServerTimeoutsProperty method?
ghost
locked as resolved and limited conversation to collaborators
Refactor code in System.Net.HttpListener to be AOT safe
Add annotations to System.Net.Http.Json to mark API as unsafe for AOT