Enable IDE0060 (Remove unused parameter) analyzer

eng/CodeAnalysis.src.globalconfig

@@ -1473,7 +1473,7 @@ dotnet_diagnostic.IDE0058.severity = silent
 dotnet_diagnostic.IDE0059.severity = warning
 
 # IDE0060: Remove unused parameter
-dotnet_diagnostic.IDE0060.severity = silent
+dotnet_diagnostic.IDE0060.severity = warning
 dotnet_code_quality_unused_parameters = non_public
 
 # IDE0061: Use expression body for local functions

src/coreclr/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshal.CoreCLR.cs

@@ -311,6 +311,7 @@ public static string GetTypeInfoName(ITypeInfo typeInfo)
             return strTypeLibName;
         }
 
+#pragma warning disable IDE0060
         // This method is identical to Type.GetTypeFromCLSID. Since it's interop specific, we expose it
         // on Marshal for more consistent API surface.
         internal static Type? GetTypeFromCLSID(Guid clsid, string? server, bool throwOnError)
@@ -327,6 +328,7 @@ public static string GetTypeInfoName(ITypeInfo typeInfo)
             GetTypeFromCLSID(clsid, server, ObjectHandleOnStack.Create(ref type));
             return type;
         }
+#pragma warning restore IDE0060
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "MarshalNative_GetTypeFromCLSID", StringMarshalling = StringMarshalling.Utf16)]
         private static partial void GetTypeFromCLSID(in Guid clsid, string? server, ObjectHandleOnStack retType);

src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs

@@ -3774,7 +3774,7 @@ private CheckValueStatus TryChangeType(
                     CorElementType dstElementType = GetUnderlyingType(this);
                     if (dstElementType != srcElementType)
                     {
-                        value = InvokeUtils.ConvertOrWiden(srcType, srcElementType, value, this, dstElementType);
+                        value = InvokeUtils.ConvertOrWiden(srcType, value, this, dstElementType);
                     }
                 }
 
@@ -3929,7 +3929,7 @@ private void CreateInstanceCheckThis()
                     }
 
                     // fast path??
-                    instance = CreateInstanceLocal(this, nonPublic: true, wrapExceptions: wrapExceptions);
+                    instance = CreateInstanceLocal(wrapExceptions: wrapExceptions);
                 }
                 else
                 {
@@ -3943,7 +3943,7 @@ private void CreateInstanceCheckThis()
 
             [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2082:UnrecognizedReflectionPattern",
                 Justification = "Implementation detail of Activator that linker intrinsically recognizes")]
-            object? CreateInstanceLocal(Type type, bool nonPublic, bool wrapExceptions)
+            object? CreateInstanceLocal(bool wrapExceptions)
             {
                 return Activator.CreateInstance(this, nonPublic: true, wrapExceptions: wrapExceptions);
             }

src/coreclr/nativeaot/Common/src/System/Collections/Concurrent/ConcurrentUnifierWKeyed.cs

@@ -161,7 +161,7 @@ public V GetOrAdd(K key)
                     return heyIWasHereFirst;
                 if (!_container.HasCapacity)
                     _container.Resize(); // This overwrites the _container field.
-                _container.Add(key, hashCode, value);
+                _container.Add(hashCode, value);
                 return value;
             }
         }
@@ -218,7 +218,7 @@ public bool TryGetValue(K key, int hashCode, out V value)
                 return false;
             }
 
-            public void Add(K key, int hashCode, V value)
+            public void Add(int hashCode, V value)
             {
                 Debug.Assert(_owner._lock.IsAcquired);
 

src/coreclr/nativeaot/Runtime.Base/src/System/AttributeUsageAttribute.cs

@@ -16,6 +16,7 @@ namespace System
     [AttributeUsage(AttributeTargets.Class, Inherited = true)]
     internal sealed class AttributeUsageAttribute : Attribute
     {
+#pragma warning disable IDE0060
         //Constructors
         public AttributeUsageAttribute(AttributeTargets validOn)
         {
@@ -24,6 +25,7 @@ public AttributeUsageAttribute(AttributeTargets validOn)
         public AttributeUsageAttribute(AttributeTargets validOn, bool allowMultiple, bool inherited)
         {
         }
+#pragma warning restore IDE0060
 
         //Properties.
         // Allowing the set properties as it allows a more readable syntax in the specifiers (and are commonly used)

src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs

@@ -74,7 +74,7 @@ private struct EHEnum
 
         // This is a fail-fast function used by the runtime as a last resort that will terminate the process with
         // as little effort as possible. No guarantee is made about the semantics of this fail-fast.
-        internal static void FallbackFailFast(RhFailFastReason reason, object unhandledException)
+        internal static void FallbackFailFast(RhFailFastReason _ /*reason*/, object _1 /*unhandledException*/)
         {
             InternalCalls.RhpFallbackFailFast();
         }
@@ -921,6 +921,7 @@ private static void InvokeSecondPass(ref ExInfo exInfo, uint idxStart, uint idxL
             }
         }
 
+#pragma warning disable IDE0060
         [UnmanagedCallersOnly(EntryPoint = "RhpFailFastForPInvokeExceptionPreemp", CallConvs = new Type[] { typeof(CallConvCdecl) })]
         public static void RhpFailFastForPInvokeExceptionPreemp(IntPtr PInvokeCallsiteReturnAddr, void* pExceptionRecord, void* pContextRecord)
         {
@@ -931,5 +932,7 @@ public static void RhpFailFastForPInvokeExceptionCoop(IntPtr classlibBreadcrumb,
         {
             FailFastViaClasslib(RhFailFastReason.UnhandledExceptionFromPInvoke, null, classlibBreadcrumb);
         }
+#pragma warning restore IDE0060
+
     } // static class EH
 }

src/coreclr/nativeaot/System.Private.CoreLib/src/System/Delegate.cs

@@ -218,7 +218,7 @@ private void InitializeClosedStaticThunk(object firstParameter, IntPtr functionP
         }
 
         // This function is known to the compiler backend.
-        private void InitializeOpenStaticThunk(object firstParameter, IntPtr functionPointer, IntPtr functionPointerThunk)
+        private void InitializeOpenStaticThunk(object _ /*firstParameter*/, IntPtr functionPointer, IntPtr functionPointerThunk)
         {
             // This sort of delegate is invoked by calling the thunk function pointer with the arguments to the delegate + a reference to the delegate object itself.
             m_firstParameter = this;
@@ -459,11 +459,5 @@ private string GetTargetMethodsDescriptionForDebugger()
                 }
             }
         }
-
-        private static string DebuggerFunctionPointerFormattingHook(IntPtr functionPointer, RuntimeTypeHandle typeOfFirstParameterIfInstanceDelegate)
-        {
-            // This method will be hooked by the debugger and the debugger will cause it to return a description for the function pointer
-            throw new NotSupportedException();
-        }
     }
 }

src/coreclr/nativeaot/System.Private.CoreLib/src/System/Enum.NativeAot.cs

@@ -16,7 +16,7 @@ namespace System
 {
     public abstract partial class Enum : ValueType, IComparable, IFormattable, IConvertible
     {
-        internal static EnumInfo GetEnumInfo(Type enumType, bool getNames = true)
+        internal static EnumInfo GetEnumInfo(Type enumType, bool _ /*getNames*/ = true)
         {
             Debug.Assert(enumType != null);
             Debug.Assert(enumType is RuntimeType);

src/coreclr/nativeaot/System.Private.CoreLib/src/System/Environment.NativeAot.cs

@@ -43,7 +43,7 @@ public static void FailFast(string message) =>
         public static void FailFast(string message, Exception exception) =>
             RuntimeExceptionHelpers.FailFast(message, exception);
 
-        internal static void FailFast(string message, Exception exception, string errorSource)
+        internal static void FailFast(string message, Exception exception, string _ /*errorSource*/)
         {
             // TODO: errorSource originates from CoreCLR (See: https://github.com/dotnet/coreclr/pull/15895)
             // For now, we ignore errorSource but we should distinguish the way FailFast prints exception message using errorSource

src/coreclr/nativeaot/System.Private.CoreLib/src/System/IO/FileLoadException.NativeAot.cs

@@ -5,7 +5,7 @@ namespace System.IO
 {
     public partial class FileLoadException
     {
-        internal static string FormatFileLoadExceptionMessage(string? fileName, int hResult)
+        internal static string FormatFileLoadExceptionMessage(string? fileName, int _ /*hResult*/)
         {
             return fileName == null ? SR.IO_FileLoad : SR.Format(SR.IO_FileLoad_FileName, fileName);
         }

src/coreclr/nativeaot/System.Private.CoreLib/src/System/InvokeUtils.cs

@@ -244,7 +244,7 @@ private static Exception CreateChangeTypeException(EETypePtr srcEEType, EETypePt
                 case CheckArgumentSemantics.SetFieldDirect:
                     return CreateChangeTypeArgumentException(srcEEType, dstEEType);
                 case CheckArgumentSemantics.ArraySet:
-                    return CreateChangeTypeInvalidCastException(srcEEType, dstEEType);
+                    return CreateChangeTypeInvalidCastException();
                 default:
                     Debug.Fail("Unexpected CheckArgumentSemantics value: " + semantics);
                     throw new InvalidOperationException();
@@ -259,7 +259,7 @@ internal static ArgumentException CreateChangeTypeArgumentException(EETypePtr sr
             return new ArgumentException(SR.Format(SR.Arg_ObjObjEx, Type.GetTypeFromHandle(new RuntimeTypeHandle(srcEEType)), destinationTypeName));
         }
 
-        private static InvalidCastException CreateChangeTypeInvalidCastException(EETypePtr srcEEType, EETypePtr dstEEType)
+        private static InvalidCastException CreateChangeTypeInvalidCastException()
         {
             return new InvalidCastException(SR.InvalidCast_StoreArrayElement);
         }

src/coreclr/nativeaot/System.Private.CoreLib/src/System/Reflection/Runtime/General/TypeUnifier.cs

@@ -253,7 +253,7 @@ private sealed class ArrayTypeTable : ConcurrentUnifierWKeyed<UnificationKey, Ru
         {
             protected sealed override RuntimeArrayTypeInfo Factory(UnificationKey key)
             {
-                ValidateElementType(key.ElementType, key.TypeHandle, multiDim: false, rank: 1);
+                ValidateElementType(key.ElementType, multiDim: false, rank: 1);
 
                 return new RuntimeArrayTypeInfo(key, multiDim: false, rank: 1);
             }
@@ -270,7 +270,7 @@ public MultiDimArrayTypeTable(int rank)
 
             protected sealed override RuntimeArrayTypeInfo Factory(UnificationKey key)
             {
-                ValidateElementType(key.ElementType, key.TypeHandle, multiDim: true, rank: _rank);
+                ValidateElementType(key.ElementType, multiDim: true, rank: _rank);
 
                 return new RuntimeArrayTypeInfo(key, multiDim: true, rank: _rank);
             }
@@ -292,7 +292,7 @@ protected sealed override MultiDimArrayTypeTable Factory(int rank)
             public static readonly TypeTableForMultiDimArrayTypeTables Table = new TypeTableForMultiDimArrayTypeTables();
         }
 
-        private static void ValidateElementType(RuntimeTypeInfo elementType, RuntimeTypeHandle typeHandle, bool multiDim, int rank)
+        private static void ValidateElementType(RuntimeTypeInfo elementType, bool multiDim, int rank)
         {
             Debug.Assert(multiDim || rank == 1);
 

src/coreclr/nativeaot/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.NativeAot.cs

@@ -25,6 +25,7 @@ public static void InitializeArray(Array array, RuntimeFieldHandle fldHandle)
             throw new PlatformNotSupportedException();
         }
 
+#pragma warning disable IDE0060
         private static unsafe void* GetSpanDataFrom(
             RuntimeFieldHandle fldHandle,
             RuntimeTypeHandle targetTypeHandle,
@@ -36,6 +37,7 @@ public static void InitializeArray(Array array, RuntimeFieldHandle fldHandle)
             // https://github.com/dotnet/corert/issues/364
             throw new PlatformNotSupportedException();
         }
+#pragma warning disable IDE0060
 
         [RequiresUnreferencedCode("Trimmer can't guarantee existence of class constructor")]
         public static void RunClassConstructor(RuntimeTypeHandle type)

src/coreclr/nativeaot/System.Private.CoreLib/src/System/Runtime/InteropServices/ComWrappers.NativeAot.cs

@@ -465,6 +465,7 @@ public object GetOrRegisterObjectForComInstance(IntPtr externalComObject, Create
             return (ComInterfaceDispatch*)comObject;
         }
 
+#pragma warning disable IDE0060
         /// <summary>
         /// Get the currently registered managed object or creates a new managed object and registers it.
         /// </summary>
@@ -541,6 +542,7 @@ private unsafe bool TryGetOrCreateObjectForComInstanceInternal(
 
             return true;
         }
+#pragma warning restore IDE0060
 
         private void RemoveRCWFromCache(IntPtr comPointer)
         {

src/coreclr/nativeaot/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshal.NativeAot.cs

@@ -180,10 +180,8 @@ public static unsafe void StructureToPtr(object structure, IntPtr ptr, bool fDel
             }
         }
 
-        private static void PrelinkCore(MethodInfo m)
-        {
-            // This method is effectively a no-op for NativeAOT, everything pre-generated.
-        }
+        // This method is effectively a no-op for NativeAOT, everything pre-generated.
+        static partial void PrelinkCore(MethodInfo m);
 
         internal static Delegate GetDelegateForFunctionPointerInternal(IntPtr ptr, Type t)
         {

src/coreclr/nativeaot/System.Private.CoreLib/src/System/Runtime/InteropServices/NativeLibrary.NativeAot.Unix.cs

@@ -9,7 +9,7 @@ public static partial class NativeLibrary
     {
         private const int LoadWithAlteredSearchPathFlag = 0;
 
-        private static IntPtr LoadLibraryHelper(string libraryName, int flags, ref LoadLibErrorTracker errorTracker)
+        private static IntPtr LoadLibraryHelper(string libraryName, int _ /*flags*/, ref LoadLibErrorTracker errorTracker)
         {
             // do the Dos/Unix conversion
             libraryName = libraryName.Replace('\\', '/');

src/coreclr/nativeaot/System.Private.CoreLib/src/System/Runtime/JitInfo.NativeAot.cs

@@ -9,6 +9,6 @@ public static partial class JitInfo
 
         public static long GetCompiledMethodCount(bool currentThread = false) => 0;
 
-        private static long GetCompilationTimeInTicks(bool currentThread = false) => 0;
+        private static long GetCompilationTimeInTicks(bool _ /*currentThread*/ = false) => 0;
     }
 }

src/coreclr/nativeaot/System.Private.CoreLib/src/System/Runtime/Loader/AssemblyLoadContext.NativeAot.cs

@@ -18,6 +18,7 @@ public Assembly LoadFromAssemblyName(AssemblyName assemblyName)
             return Assembly.Load(assemblyName);
         }
 
+#pragma warning disable IDE0060
         private static IntPtr InitializeAssemblyLoadContext(IntPtr ptrAssemblyLoadContext, bool fRepresentsTPALoadContext, bool isCollectible)
         {
             return IntPtr.Zero;
@@ -46,6 +47,7 @@ private static Assembly InternalLoadFromPath(string? assemblyPath, string? nativ
             // so it won't actually work properly when multiple assemblies with the same identity get loaded.
             return ReflectionAugments.ReflectionCoreCallbacks.Load(assemblyPath);
         }
+#pragma warning restore IDE0060
 
 #pragma warning disable CA1822
         internal Assembly InternalLoad(ReadOnlySpan<byte> arrAssembly, ReadOnlySpan<byte> arrSymbols)

src/coreclr/nativeaot/System.Private.CoreLib/src/System/Threading/Thread.NativeAot.Unix.cs

@@ -28,7 +28,7 @@ private void PlatformSpecificInitializeExistingThread()
             _stopped = new ManualResetEvent(false);
         }
 
-#pragma warning disable CA1822
+#pragma warning disable CA1822, IDE0060
         private ThreadPriority GetPriorityLive()
         {
             return ThreadPriority.Normal;
@@ -38,7 +38,7 @@ private bool SetPriorityLive(ThreadPriority priority)
         {
             return true;
         }
-#pragma warning restore CA1822
+#pragma warning restore CA1822, IDE0060
 
         [UnmanagedCallersOnly]
         private static void OnThreadExit()

src/coreclr/nativeaot/System.Private.CoreLib/src/System/Threading/ThreadPool.NativeAot.cs

@@ -10,8 +10,6 @@
 **
 =============================================================================*/
 
-#pragma warning disable 0420
-
 using System.Diagnostics;
 using System.Runtime.InteropServices;
 using System.Runtime.Versioning;
@@ -20,6 +18,7 @@ namespace System.Threading
 {
     public static partial class ThreadPool
     {
+        [Conditional("unnecessary")]
         internal static void ReportThreadStatus(bool isWorking)
         {
         }

src/coreclr/nativeaot/System.Private.CoreLib/src/System/Threading/ThreadPool.Windows.cs

@@ -357,7 +357,7 @@ public static void GetAvailableThreads(out int workerThreads, out int completion
         internal static void NotifyWorkItemProgress() => IncrementCompletedWorkItemCount();
 
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        internal static bool NotifyWorkItemComplete(object? threadLocalCompletionCountObject, int currentTimeMs)
+        internal static bool NotifyWorkItemComplete(object? threadLocalCompletionCountObject, int _ /*currentTimeMs*/)
         {
             ThreadInt64PersistentCounter.Increment(threadLocalCompletionCountObject);
             return true;

src/coreclr/nativeaot/System.Private.CoreLib/src/System/ValueType.cs

@@ -109,7 +109,7 @@ private int GetHashCodeImpl()
             if (numFields == UseFastHelper)
                 return FastGetValueTypeHashCodeHelper(this.GetEETypePtr(), ref this.GetRawData());
 
-            return RegularGetValueTypeHashCode(this.GetEETypePtr(), ref this.GetRawData(), numFields);
+            return RegularGetValueTypeHashCode(ref this.GetRawData(), numFields);
         }
 
         private static int FastGetValueTypeHashCodeHelper(EETypePtr type, ref byte data)
@@ -128,7 +128,7 @@ private static int FastGetValueTypeHashCodeHelper(EETypePtr type, ref byte data)
             return hashCode;
         }
 
-        private int RegularGetValueTypeHashCode(EETypePtr type, ref byte data, int numFields)
+        private int RegularGetValueTypeHashCode(ref byte data, int numFields)
         {
             int hashCode = 0;
 

src/coreclr/nativeaot/System.Private.TypeLoader/src/Internal/Runtime/TypeLoader/GenericDictionaryCell.cs

@@ -719,7 +719,7 @@ internal override unsafe void Prepare(TypeBuilder builder)
                         case TypeLoaderEnvironment.MethodAddressType.Canonical:
                             {
                                 bool methodRequestedIsCanonical = Method.IsCanonicalMethod(CanonicalFormKind.Specific);
-                                bool requestedMethodNeedsDictionaryWhenCalledAsCanonical = NeedsDictionaryParameterToCallCanonicalVersion(Method);
+                                bool requestedMethodNeedsDictionaryWhenCalledAsCanonical = NeedsDictionaryParameterToCallCanonicalVersion();
 
                                 if (!requestedMethodNeedsDictionaryWhenCalledAsCanonical || methodRequestedIsCanonical)
                                 {
@@ -731,7 +731,7 @@ internal override unsafe void Prepare(TypeBuilder builder)
                         case TypeLoaderEnvironment.MethodAddressType.UniversalCanonical:
                             {
                                 if (Method.IsCanonicalMethod(CanonicalFormKind.Universal) &&
-                                    !NeedsDictionaryParameterToCallCanonicalVersion(Method) &&
+                                    !NeedsDictionaryParameterToCallCanonicalVersion() &&
                                     !UniversalGenericParameterLayout.MethodSignatureHasVarsNeedingCallingConventionConverter(
                                         Method.GetTypicalMethodDefinition().Signature))
                                 {
@@ -792,7 +792,7 @@ internal override unsafe void Prepare(TypeBuilder builder)
                 Debug.Assert((_exactFunctionPointer != IntPtr.Zero) || (Method.FunctionPointer != IntPtr.Zero) || (Method.UsgFunctionPointer != IntPtr.Zero));
             }
 
-            private bool NeedsDictionaryParameterToCallCanonicalVersion(MethodDesc method)
+            private bool NeedsDictionaryParameterToCallCanonicalVersion()
             {
                 if (Method.HasInstantiation)
                     return true;

src/coreclr/nativeaot/System.Private.TypeLoader/src/Internal/Runtime/TypeLoader/LowLevelStringConverter.cs

@@ -41,12 +41,12 @@ public static string ToStringInvariant(this ulong arg)
             return arg.LowLevelToString();
         }
 
-        public static string ToStringInvariant(this float arg)
+        public static string ToStringInvariant(this float _)
         {
             return "FLOAT";
         }
 
-        public static string ToStringInvariant(this double arg)
+        public static string ToStringInvariant(this double _)
         {
             return "DOUBLE";
         }