Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ICorProfilerInfo13 to support object handle creation/destruction/access #71257

Merged
merged 15 commits into from
Jul 16, 2022
Merged

Implement ICorProfilerInfo13 to support object handle creation/destruction/access #71257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
fe1ff8e
Implement ICorProfilerInfo13 to support object handle creation/destru…
chrisnas Jun 23, 2022
494e14b
Add test for ICorProfilerInfo13 methods about handle management
chrisnas Jun 26, 2022
8dee5e4
Fix compilation issues
chrisnas Jun 27, 2022
db61ba1
Remove TAB
chrisnas Jun 30, 2022
a498ec2
Fix build issues
chrisnas Jun 30, 2022
e3663d1
Complete handles test
chrisnas Jun 30, 2022
6b56f14
Fix Linux compilation error
chrisnas Jul 1, 2022
43d0063
Fix test build issue
chrisnas Jul 2, 2022
de83528
Improve handles test
chrisnas Jul 2, 2022
d0a40a1
Fix build error
chrisnas Jul 3, 2022
d6f8bc5
Add logs in handles test
chrisnas Jul 3, 2022
9d7139f
Add type information to handles test logs
chrisnas Jul 4, 2022
21e7afa
Take review comments into account
chrisnas Jul 6, 2022
ba6d3f8
Add logs to handles test
chrisnas Jul 6, 2022
89d5b0f
Fix test error
chrisnas Jul 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions src/coreclr/inc/corprof.idl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,6 +836,15 @@ typedef struct
UINT32 reserved;
} COR_PRF_EVENT_DATA;

typedef enum _COR_PRF_HANDLE_TYPE
{
COR_PRF_HANDLE_TYPE_WEAK = 0x1,
COR_PRF_HANDLE_TYPE_STRONG = 0x2,
COR_PRF_HANDLE_TYPE_PINNED = 0x3,
} COR_PRF_HANDLE_TYPE;

typedef void** ObjectHandleID;

/* -------------------------------------------------------------------------- *
* Forward declarations
* -------------------------------------------------------------------------- */
Expand Down Expand Up @@ -4215,6 +4224,27 @@ interface ICorProfilerInfo12 : ICorProfilerInfo11
[in] LPCGUID pRelatedActivityId);
}

[
object,
uuid(6E6C7EE2-0701-4EC2-9D29-2E8733B66934),
pointer_default(unique),
local
]
interface ICorProfilerInfo13 : ICorProfilerInfo12
{
HRESULT CreateHandle(
[in] ObjectID object,
[in] COR_PRF_HANDLE_TYPE type,
[out] ObjectHandleID* pHandle);

HRESULT DestroyHandle(
[in] ObjectHandleID handle);

HRESULT GetObjectIDFromHandle(
[in] ObjectHandleID handle,
[out] ObjectID* pObject);
}

/*
* This interface lets you iterate over methods in the runtime.
*/
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/pal/prebuilt/idl/corprof_i.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ MIDL_DEFINE_GUID(IID, IID_ICorProfilerInfo11,0x06398876,0x8987,0x4154,0xB6,0x21,
MIDL_DEFINE_GUID(IID, IID_ICorProfilerInfo12,0x27b24ccd,0x1cb1,0x47c5,0x96,0xee,0x98,0x19,0x0d,0xc3,0x09,0x59);


MIDL_DEFINE_GUID(IID, IID_ICorProfilerInfo13,0x19C4179D,0xF92C,0x4D25,0x9F,0x20,0x5F,0xEB,0xFB,0xBD,0x29,0x78);
MIDL_DEFINE_GUID(IID, IID_ICorProfilerInfo13,0x6E6C7EE2,0x0701,0x4EC2,0x9D,0x29,0x2E,0x87,0x33,0xB6,0x69,0x34);


MIDL_DEFINE_GUID(IID, IID_ICorProfilerMethodEnum,0xFCCEE788,0x0088,0x454B,0xA8,0x11,0xC9,0x9F,0x29,0x8D,0x19,0x42);
Expand Down
Loading