Update Maui Workload Install Process for Perf #64692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test if new dotnet version can be installed similar to how it is done in the Maui repo.
…r workload install.
|
Tagging subscribers to this area: @hoyosjs Issue DetailsFixes dotnet/performance#2230, where an error with installing the latest Maui workload would occur but not error out the pipeline. This fixes that by installing the latest 6.0.2xx dotnet sdk for installing the workload and building the Maui apps.
|
|
Perf run succeeded where expected on a private run, merging. |
eerhardt
reviewed
Feb 3, 2022
| curl -o dotnet-install.sh 'https://dotnet.microsoft.com/download/dotnet/scripts/v1/dotnet-install.sh' | ||
| chmod -R a+rx . | ||
| ./dotnet-install.sh --channel 6.0.2xx --quality signed --install-dir . | ||
| ./dotnet --info |
There was a problem hiding this comment.
What's this line for? Is it needed?
| mv ./bin/Release/net6.0-android/com.companyname.MauiTesting-Signed.apk ./MauiAndroidDefault.apk | ||
| displayName: Build MAUI Android | ||
| workingDirectory: $(Build.SourcesDirectory)/MauiTesting | ||
|
|
||
| - script: | | ||
| chmod -R a+r . | ||
| ../dotnet.sh publish -bl:MauiiOS.binlog -f net6.0-ios -c Release | ||
| ../dotnet build -bl:MauiiOS.binlog -f net6.0-ios -c Release |
There was a problem hiding this comment.
What I've found to work is:
- Remove the
net6.0-maccatalystTFM from theTargetFrameworksproperty in the .csproj. dotnet publish -c Release -f net6.0-ios -r ios-arm64
I've logged xamarin/xamarin-macios#14015 for this, which was closed in favor of dotnet/sdk#21877.
| mv ./bin/Release/net6.0-ios/iossimulator-x64/MauiTesting.app ./MauiiOSDefault.app | ||
| displayName: Build MAUI iOS | ||
| workingDirectory: $(Build.SourcesDirectory)/MauiTesting | ||
|
|
||
| - script: | | ||
| chmod -R a+r . | ||
| ../dotnet.sh publish -bl:MauiMacCatalyst.binlog -f net6.0-maccatalyst -c Release | ||
| ../dotnet publish -bl:MauiMacCatalyst.binlog -f net6.0-maccatalyst -c Release |
There was a problem hiding this comment.
Do we care about maccatalyst size? I'm not certain this is an important scenario to track. It may just be wasting resources and cluttering the perf dashboard.
LoopedBard3
added a commit
to LoopedBard3/runtime
that referenced
this pull request
Feb 8, 2022
* Add dotnet install and run to test if new dotnet version can be installed similar to how it is done in the Maui repo. * Download and use local dotnet version. * Use updated dotnet for more of the pipeline. * Test with made runtime packs and and add ios arm pack substitution. * Try building instead of publishing. * Reenable everything for full test run. * Package name now seems to default to lower case, at least for maui.
LoopedBard3
added a commit
to LoopedBard3/runtime
that referenced
this pull request
Feb 10, 2022
* Add dotnet install and run to test if new dotnet version can be installed similar to how it is done in the Maui repo. * Download and use local dotnet version. * Use updated dotnet for more of the pipeline. * Test with made runtime packs and and add ios arm pack substitution. * Try building instead of publishing. * Reenable everything for full test run. * Package name now seems to default to lower case, at least for maui.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/performance#2230, where an error with installing the latest Maui workload would occur but not error out the pipeline. This fixes that by installing the latest 6.0.2xx dotnet sdk for installing the workload and building the Maui apps. Includes some minor name fixes and adds ios runtime building.