[wasm] Backport build improvements, and fixes from #61581 #62757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VS does its own tracking of inputs/outputs too, and needs to be told about `@(NativeFileReference)` items, so a build can get triggered with F5 when a native file changes. Based on https://github.com/dotnet/project-system/blob/main/docs/up-to-date-check.md?rgh-link-date=2021-10-26T13%3A23%3A47Z#up-to-date-check Fixes dotnet#60862
…attributes Inspired by https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1364890?src=WorkItemMention&src-action=artifact_link Works around a NRE in CustomAttributeData.AttributeType because it's ConstructorInfo is null. The mono side issue: mono/mono#15340
radical
changed the title
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsBackport of #61581 to release/6.0 Fixes #60862 Customer ImpactImproves incremental builds in VS, when using native references (#60862), pinvoke signature generation, and surfaces error details in AOT compilation. TestingUnit tests, and manual testing. RiskLow risk
|
|
Approved over email. |
radical
added
Servicing-approved
|
Closing and reopening to trigger CI again. |
lewing
approved these changes
Dec 15, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #61581 to release/6.0
Fixes #60862
Partially fixes #60800
Customer Impact
Improves incremental builds in VS when using native references (#60862), pinvoke signature generation, and surfaces error details in AOT compilation. The pinvoke signature generation has been expanded to use only valid characters in the function name, which improves on the earlier approach of replacing some known invalid characters.
Testing
Unit tests, and manual testing.
Risk
Low risk.