[iOS] Follow up changes for 61590 #61670
Conversation
…orm attribute on iOS/tvOS
MaximLipnin
requested review from
marek-safar,
directhex,
simonrozsival,
steveisok,
akoeplinger and
mdh1418
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-system-diagnostics-process Issue DetailsThis is a follow up PR for #61590. It should include:
|
src/libraries/System.Diagnostics.Process/src/System.Diagnostics.Process.csproj
Outdated
Show resolved
Hide resolved
|
/azp run runtime-staging-manual |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Tagging subscribers to 'os-ios': @steveisok, @akoeplinger Issue DetailsThis is a follow up PR for #61590. It should include:
|
|
The failures on the mobile lanes are known and not related to the current S.D.P. changes. |
|
Filed #61783 for a crash in S.S.Cryptography.Tests on Android. |
This is a follow up PR for dotnet#61590. It includes: - additional UnsupportedOSPlatform annotations for some System.Diagnostics.Process APIs throwing PNSE on iOS/tvOS (they started doing so after excluding some managed logic around librpoc ) - fixing a bit ugly workaround for CS0649 (see https://github.com/dotnet/runtime/pull/61590/files#r749525127) - used a local pragma in the ThreadInfo class. - skipping the respective S.D.P. tests ( it will address [iOS/tvOS] System.Diagnostics.Tests.ProcessTests.TestGetProcesses fails on devices dotnet#60588 as well)
#62235) * Exclude the managed code around libproc on iOS/tvOS (#61590) Since libproc is a private Apple API, it is not available on iOS/tvOS and should be excluded (see #61265 (comment) and above for more details). This PR excludes $(CommonPath)Interop\OSX\Interop.libproc.cs on the iOS/tvOS as well as makes some methods in Process, ProcessManager, and ProcessThread classes calling that API throw PNSE so that for iOS/tvOS it's possible to re-use the respective *.UnknownUnix.cs parts. * [iOS] Follow up changes for 61590 (#61670) This is a follow up PR for #61590. It includes: - additional UnsupportedOSPlatform annotations for some System.Diagnostics.Process APIs throwing PNSE on iOS/tvOS (they started doing so after excluding some managed logic around librpoc ) - fixing a bit ugly workaround for CS0649 (see https://github.com/dotnet/runtime/pull/61590/files#r749525127) - used a local pragma in the ThreadInfo class. - skipping the respective S.D.P. tests ( it will address [iOS/tvOS] System.Diagnostics.Tests.ProcessTests.TestGetProcesses fails on devices #60588 as well) * Skip System.Diagnostics.TextWriterTraceListenerTests.XmlWriterTraceListenerTests on iOS/tvOS (#61807) This marks System.Diagnostics.TextWriterTraceListenerTests.XmlWriterTraceListenerTests withSkipOnPlatform attribute for iOS/tvOS as those tests try to create a process info, which throws PNSE after S.D.Process API's around libproc have been excluded in #61590. * Disable several failing tests on iOSSimulator arm64 #61826 A few tests popped up as failures on the rolling build due to parts of System.Diagnostics.Process throwing PNSE. Disabled the functional tests from running on arm64 as mlaunch can't detect the return code. * Use separate partials for iOS&tvOS instead of UnknowUnix in System.Diagnostics.Process (#61871) * Remove NoWarn removal
ghost
locked as resolved and limited conversation to collaborators
This is a follow up PR for #61590.
It should include:
additional
UnsupportedOSPlatformannotations for someSystem.Diagnostics.ProcessAPIs throwing PNSE on iOS/tvOS (they started doing so after excluding some managed logic aroundlibrpoc)fixing a bit ugly workaround for CS0649 (see https://github.com/dotnet/runtime/pull/61590/files#r749525127) - used a local pragma in the
ThreadInfoclass.skipping the respective S.D.P. tests ( it will address [iOS/tvOS] System.Diagnostics.Tests.ProcessTests.TestGetProcesses fails on devices #60588 as well):
TestModuleProperties
Modules_Get_ContainsHostFileName
StartTime_GetNotStarted_ThrowsInvalidOperationException
TestMainModule
UserProcessorTime_GetNotStarted_ThrowsInvalidOperationException
PriviledgedProcessorTime_GetNotStarted_ThrowsInvalidOperationException
TotalProcessorTime_GetNotStarted_ThrowsInvalidOperationException
TestGetProcesses
GetProcessesByName_ProcessName_ReturnsExpected
GetProcessesByName_ProcessNameMachineName_ReturnsExpected
GetProcessesByName_NoSuchProcess_ReturnsEmpty
GetProcessesByName_NullMachineName_ThrowsArgumentNullException
GetProcessesByName_EmptyMachineName_ThrowsArgumentException
StartInfo_SetGet_ReturnsExpected
RefreshResetsAllRefreshableFields
TestThreadCount
TestStartAddressProperty
Kill_EntireProcessTree_True_ProcessNotStarted_ThrowsInvalidOperationException
Kill_EntireProcessTree_True_CalledOnCallingProcess_ThrowsInvalidOperationException