[release/6.0] Fix UnobservedTaskException from SemaphoreSlim.WaitAsync #61491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://github.com/avatars/in/15368?s=60&v=4){kind=small}
If a SemaphoreSlim.WaitAsync times out, it correctly returns false, but it also results in TaskScheduler.UnobservedTaskException being raised unexpectedly, due to internal use of a faulted task whose exception isn't observed. This fixes that by marking any such exceptions as having been observed.
|
Tagging subscribers to this area: @mangod9 Issue DetailsBackport of #60890 to release/6.0 /cc @stephentoub Customer ImpactTestingRisk
|
adamsitnik
approved these changes
Nov 12, 2021
danmoseley
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #60890 to release/6.0
/cc @stephentoub
Customer Impact
If a developer uses SemaphoreSlim.WaitAsync with a timeout and it times out, the TaskScheduler.UnobservedTaskException event will erroneously be raised with a TimeoutException due to the exception that gets generated internally. This ends up being noise in an event devs typically use to know when something they're supposed to have handled has gone unhandled.
Testing
Manual testing plus a new unit test.
Risk
Low.