Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in profiler method #60999

Merged
merged 2 commits into from
Nov 2, 2021
Merged

Fix typo in profiler method #60999

merged 2 commits into from
Nov 2, 2021

Conversation

davmason
Copy link
Member

Fixes #60965

@davmason davmason added this to the 7.0.0 milestone Oct 29, 2021
@davmason davmason requested a review from a team October 29, 2021 03:35
@davmason davmason self-assigned this Oct 29, 2021
@ghost
Copy link

ghost commented Oct 29, 2021

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #60965

Author: davmason
Assignees: davmason
Labels:

area-Diagnostics-coreclr

Milestone: 7.0.0

Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -8374,7 +8374,7 @@ EXTERN_C const IID IID_ICorProfilerCallback11;
ICorProfilerCallback11 : public ICorProfilerCallback10
{
public:
virtual HRESULT STDMETHODCALLTYPE LoadAsNotficationOnly(
virtual HRESULT STDMETHODCALLTYPE LoadAsNotificationOnly(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The breaking change might be worth a heads up on the profiler announcement issue, but I agree it seems unlikely to affect many people and easy to resolve

@davmason davmason merged commit c690d27 into dotnet:main Nov 2, 2021
@davmason davmason deleted the profiler_typo branch November 2, 2021 10:18
@ghost ghost locked as resolved and limited conversation to collaborators Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICorProfilerCallback11 typo
2 participants