Pass excludemonofailures in managed test build job for mono #56434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @directhex Issue Details
|
jkoritzinsky
approved these changes
Jul 27, 2021
AaronRobinsonMSFT
approved these changes
Jul 27, 2021
elinor-fung
force-pushed
the
testRuntimeFlavor-ci
branch
from
3927380
to
52d595c
Compare
AaronRobinsonMSFT
approved these changes
Jul 28, 2021
elinor-fung
force-pushed
the
testRuntimeFlavor-ci
branch
from
52d595c
to
4ce5050
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The managed test build job was building with
RuntimeFlavor=CoreCLR. This means that managed test projects could not avoid being built for Mono. They would always be built and then rely on exclusions in issues.targets to avoid creating a test wrapper and running them.