Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build runtime.native.System.IO.Ports on linux-s390x #56424

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Build runtime.native.System.IO.Ports on linux-s390x #56424

merged 1 commit into from
Jul 28, 2021

Conversation

uweigand
Copy link
Contributor

  • Add RID to runtime.native.System.IO.Ports/netcoreapp.rids.props

  • Update runtime.native.System.IO.Ports.pkgproj file.

* Add RID to runtime.native.System.IO.Ports/netcoreapp.rids.props

* Update runtime.native.System.IO.Ports.pkgproj file.
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 27, 2021
@ghost
Copy link

ghost commented Jul 27, 2021

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Add RID to runtime.native.System.IO.Ports/netcoreapp.rids.props

  • Update runtime.native.System.IO.Ports.pkgproj file.

Author: uweigand
Assignees: -
Labels:

area-System.IO, community-contribution

Milestone: -

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the CI failures are unrelated (#56459)

@adamsitnik
Copy link
Member

@ViktorHofer it seems that the license check got stuck:

obraz

is there any way I could re-run it?

@ViktorHofer
Copy link
Member

Hmm that I don't know. Closing and reopening the PR (after waiting a minute or so) should retrigger all checks.

@adamsitnik adamsitnik closed this Jul 28, 2021
@adamsitnik adamsitnik reopened this Jul 28, 2021
@adamsitnik adamsitnik added this to the 6.0.0 milestone Jul 28, 2021
@adamsitnik adamsitnik merged commit 5d2229e into dotnet:main Jul 28, 2021
@adamsitnik
Copy link
Member

Closing and reopening the PR (after waiting a minute or so) should retrigger all checks.

That did the trick, thanks!

@lewing
Copy link
Member

lewing commented Aug 4, 2021

This appears to be blocking code flow on #56719 and probably needs to be reverted

cc @jeffhandley

@jeffhandley
Copy link
Member

Thanks, @lewing! 👀

@ViktorHofer
Copy link
Member

ViktorHofer commented Aug 5, 2021

@uweigand unfortunately we need to revert this change as it's causing the restore the meta package runtime.native.System.IO.Ports.nupkg to fail.

Reason for that is the meta package (by design) references all runtime specific packages. With your PR the runtime.linux-s390x.runtime.native.System.IO.Ports.nupkg is now referenced by the meta package but that runtime specific package isn't built in our official builds and hence missing from the package feed.

We should discuss if there's a better design i.e. avoiding the meta package. Meanwhile as said I will revert the change as part of #56906.

@uweigand
Copy link
Contributor Author

uweigand commented Aug 6, 2021

Sorry for the breakage, I wasn't aware the patch would have this effect.

When this is reverted, the package simply won't be built again on s390x, which means the feature set enabled by this native library will not be available, right? This seems to be mostly about support for serial ports, modems, etc., so it may not actually be a showstopper if this isn't available. However, just for completeness, it would be preferable to support the same feature set as on Intel and Arm ...

There is another set of "meta" packages (DotNetHost*), where it seems possible to add a RID even if it isn't part of the official builds. See #56423 (which hasn't been reviewed yet). Would it be possible to use that mechanism also for the System.IO.Ports package?

@ghost ghost locked as resolved and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.IO.Ports community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants