Have HttpClientHandler throw the InnerException when catching TargetInvocationException #56334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvocationException Originally on mobile workloads when UseNativeHttpHandler is set to true, all reflection method invokes bubbled up a TargetInvocationException. To make the details a bit more readable, we will instead rethrow the InnerException. Fixes dotnet#56089
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsOriginally on mobile workloads when UseNativeHttpHandler is set to true, all reflection method invokes Fixes #56089
|
mdh1418
reviewed
Jul 27, 2021
| catch (TargetInvocationException e) | ||
| { | ||
| ExceptionDispatchInfo.Capture(e.InnerException!).Throw(); | ||
| throw; |
There was a problem hiding this comment.
Redundant? Wouldn't the line above already throw?
There was a problem hiding this comment.
It's needed to trick the analyzer.
mdh1418
approved these changes
Jul 27, 2021
|
Could use the static method ExceptionDispatchInfo.Throw(Exception) from dotnet/coreclr#10489, if this isn't targeting any older frameworks. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally on mobile workloads when UseNativeHttpHandler is set to true, all reflection method invokes
bubbled up a TargetInvocationException. To make the details a bit more readable, we will instead rethrow
the InnerException.
Fixes #56089