Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing entrypoints and add build-time validation #54785

Merged
merged 3 commits into from
Jun 28, 2021

Conversation

vcsjones
Copy link
Member

@vcsjones vcsjones commented Jun 27, 2021

This adds a bunch of missing DllImportEntrys and brings in build-time validation to prevent any additional drift.

Closes #54784

/cc @VSadov

@ghost
Copy link

ghost commented Jun 27, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

This adds a bunch of missing DllImportEntrys and brings in build-time validation to prevent any additional drift.

/cc @VSadov

Author: vcsjones
Assignees: -
Labels:

area-System.Security

Milestone: -

@vcsjones
Copy link
Member Author

Example output when I added an exported function without including it in the entry point list:

EXEC : error : /Users/kjones/Projects/dotnet/runtime-main/src/libraries/Native/Unix/System.Security.Cryptography.Native.Apple/../../Unix/System.Security.Cryptography.Native.Apple/entrypoints.c file did not match entries exported from /Users/kjones/Projects/dotnet/runtime-main/artifacts/obj/native/net6.0-OSX-Debug-x64/System.Security.Cryptography.Native.Apple/libSystem.Security.Cryptography.Native.Apple.dylib [/Users/kjones/Projects/dotnet/runtime-main/src/libraries/Native/build-native.proj]
  DIFFERENCES FOUND: 
  AppleCryptoNative_Potato

Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you!!

@ghost
Copy link

ghost commented Jun 27, 2021

Tagging subscribers to this area: @agocke, @vitek-karas, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

This adds a bunch of missing DllImportEntrys and brings in build-time validation to prevent any additional drift.

Closes #54784

/cc @VSadov

Author: vcsjones
Assignees: -
Labels:

area-Single-File, area-System.Security

Milestone: -

…Apple/CMakeLists.txt

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@jkotas jkotas merged commit 15b4d9a into dotnet:main Jun 28, 2021
@vcsjones vcsjones deleted the fix-54784 branch June 28, 2021 01:16
@ghost ghost locked as resolved and limited conversation to collaborators Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entrypoint verification should work on Apple platforms
3 participants