-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First round of converting System.Drawing.Common to COMWrappers #54636
Merged
Commits on Jun 23, 2021
-
First round of converting System.Drawing.Common to COMWrappers
Using COM Wrappers makes the library trim compatible.
Configuration menu - View commit details
-
Copy full SHA for df5df6c - Browse repository at this point
Copy the full SHA df5df6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b809c88 - Browse repository at this point
Copy the full SHA b809c88View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcf3cfd - Browse repository at this point
Copy the full SHA dcf3cfdView commit details -
* Use function pointers instead of delegates * Rename Guid to IID * Better interop to closely match the native side * Release any COM pointer that was QueryInterface * Use pointers instead of Marshal.PtrToStructure/StructureToPtr
Configuration menu - View commit details
-
Copy full SHA for c3d76ba - Browse repository at this point
Copy the full SHA c3d76baView commit details
Commits on Jun 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for e6cd213 - Browse repository at this point
Copy the full SHA e6cd213View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84559f6 - Browse repository at this point
Copy the full SHA 84559f6View commit details -
* No need for a VTable struct, just set each function pointer right into the table * Wrap all managed calls in try-catch and return HResult
Configuration menu - View commit details
-
Copy full SHA for 75a7ddd - Browse repository at this point
Copy the full SHA 75a7dddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12f52f8 - Browse repository at this point
Copy the full SHA 12f52f8View commit details -
* Rename methods * Use COM naming * Fix method signature to use pointer instead of out. * CheckStatus => ThrowExceptionForHR
Configuration menu - View commit details
-
Copy full SHA for 6cb2d99 - Browse repository at this point
Copy the full SHA 6cb2d99View commit details
Commits on Jun 26, 2021
-
* Pass -1 to Marshal.GetExceptionForHR so it doesn't query GetErrorInfo, and always returns the correct exception type * Create the PictureWrapper with UniqueInstance, so it doesn't get cached. Caching it causes lifetime issues.
Configuration menu - View commit details
-
Copy full SHA for 3c657bc - Browse repository at this point
Copy the full SHA 3c657bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 25cc9e7 - Browse repository at this point
Copy the full SHA 25cc9e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39e5fc6 - Browse repository at this point
Copy the full SHA 39e5fc6View commit details
Commits on Jun 27, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 284da55 - Browse repository at this point
Copy the full SHA 284da55View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.