Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import cgt.un(op, 0) as NE(op, 0) #54539

Merged
merged 3 commits into from
Jul 13, 2021
Merged

Import cgt.un(op, 0) as NE(op, 0) #54539

merged 3 commits into from
Jul 13, 2021

Commits on Jun 22, 2021

  1. Some minor code modernization 

    Use "genActualType" directly as it is now a templated method.

Don't create casts to TYP_ULONG - they are identical to casts
to TYP_LONG. TYP_ULONG is only relevant for checked casts.

Add a TODO on addressing the duplicated logic that upcasts to
native int from int32 on 64 bit.

Use modern comments.

Zero diffs.
    @SingleAccretion
    SingleAccretion committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    6f598f0 View commit details
    Browse the repository at this point in the history

  2. Normalize GT_UN(op, 0) early in importer 

    Normalizing this idiom helps downstream optimizations.
    @SingleAccretion
    SingleAccretion committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    d2dd580 View commit details
    Browse the repository at this point in the history

  3. Solve most of the regressions 

    In morph, when narrowing the AND operand, only
insert casts if necessary - prefer to use "optNarrowTree".
Otherwise we end up with redundant register shuffling.
    @SingleAccretion
    SingleAccretion committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    3b61c12 View commit details
    Browse the repository at this point in the history