Remove System.Drawing code that doesn't work

[eerhardt]

This code only runs on macOS, and expects mono's System.Windows.Forms assembly is loaded into the process. This is causing trim warnings, and it is easier just to delete this code than try to make ILLink happy.

This code is only called from Graphics.FromHwnd, which doesn't work because the Carbon.framework no longer exists on macOS. Issue #22221 is tracking the test failures that use FromHwnd.

Tagging the mono runtime devs I think might be interested here: @lambdageek @vargaz @marek-safar @steveisok @lewing @SamMonoRT

[ghost]

Tagging subscribers to this area: @safern, @tarekgh
See info in area-owners.md if you want to be subscribed.

Issue Details

---

This code only runs on macOS, and expects mono's System.Windows.Forms assembly is loaded into the process. This is causing trim warnings, and it is easier just to delete this code than try to make ILLink happy.

This code is only called from Graphics.FromHwnd, which doesn't work because the Carbon.framework no longer exists on macOS. Issue #22221 is tracking the test failures that use FromHwnd.

Tagging the mono runtime devs I think might be interested here: @lambdageek @vargaz @marek-safar @steveisok @lewing @SamMonoRT

Author:	eerhardt
Assignees:	-
Labels:	area-System.Drawing
Milestone:	-

[safern]

LGTM. If we ever want to support this we needed to rewrite it anyway because Carbon framework is no longer available in our supported macOS platforms. We would need to use Cocoa.

[eerhardt]

/azp run

[azure-pipelines]

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

[eerhardt]

/azp run runtime

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[eerhardt]

Test failure is #54301.

[akoeplinger]

@safern FYI the Carbon.framework still exists on an M1 Big Sur, not sure where you saw it being removed.

[eerhardt]

Our code doesn't appear to work on my mac:

Console.WriteLine(Graphics.FromHwnd(IntPtr.Zero));

Causes the following exception:

System.EntryPointNotFoundException has been thrown

"Unable to find an entry point named 'GetQDGlobalsThePort' in shared library '/System/Library/Frameworks/Carbon.framework/Versions/Current/Carbon'."

This seems to be similar: https://bugzilla.xamarin.com/56/56613/bug.html

[safern]

I followed up with @akoeplinger and it is not like that the framework was removed but a lot of the APIs were removed, so some entry points we use no longer exist in the shared library.