Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for IServiceProviderIsService #54047

Merged
merged 6 commits into from
Jun 11, 2021
Merged

Add support for IServiceProviderIsService #54047

merged 6 commits into from
Jun 11, 2021

Commits on Jun 11, 2021

  1. Add support for IServiceProviderIsService 

    - This optional service lets consumers query to see if a service is resolvable without side effects (not having to explicitly resolve the service).
- Added new spec tests to verify the baseline behavior based on IServiceCollection features.
    @davidfowl
    davidfowl committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    754dd34 View commit details
    Browse the repository at this point in the history

  2. PR feedback, add IEnumerable open generic test

    @davidfowl
    davidfowl committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    b413e7a View commit details
    Browse the repository at this point in the history

  3. PR feedback

    @davidfowl
    davidfowl committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    81c89f2 View commit details
    Browse the repository at this point in the history

  4. Update src/libraries/Microsoft.Extensions.DependencyInjection.Abstrac… 

    …tions/src/IServiceProviderIsService.cs

Co-authored-by: Travis Illig <tillig@paraesthesia.com>
    @davidfowl @tillig
    davidfowl and tillig authored Jun 11, 2021
    Configuration menu
    Copy the full SHA
    b556a0e View commit details
    Browse the repository at this point in the history

  5. Handle built in services as part of IsServce 

    - Special case built in services as part of the IsService check
- Added a test case
    @davidfowl
    davidfowl committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    6aeff37 View commit details
    Browse the repository at this point in the history

  6. PR feedback 

    - Make the tests part of the core DI tests and enable skipping via a property
    @davidfowl
    davidfowl committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    8f7d3ec View commit details
    Browse the repository at this point in the history