[release/5.0] Handle Counter Polling Interval of 0 #54035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://github.com/avatars/in/15368?s=60&v=4){kind=small}
added 4 commits
June 10, 2021 22:40
…sEnabled after not holding lock * add test for setting interval to 0
|
Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti |
|
I'll update the test to the one in #54081 once it merges |
jeffschwMSFT
added
the
Servicing-consider
jeffschwMSFT
approved these changes
Jun 15, 2021
leecow
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #53836 to release/5.0
/cc @hoyosjs @josalem
Customer Impact
When listening to EventCounters there is a dedicated thread that is supposed to publish the metric values via EventSource on a periodic timer. However due a bug it is possible to put it into an infinite loop here. This occurs any time _pollingIntervalMilliseconds <= 0, which could occur for a few reasons:
(from #53564)
Testing
The included test covers scenario 1, and manual testing was done for scenario 2.
Risk
This patch reduces overall risk by removing any looping based on user input. This should prevent scenario 1 and 2 above.