Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Array.Clear(Array) publicly #53388

Merged
merged 5 commits into from
May 28, 2021

Conversation

GrabYourPitchforks
Copy link
Member

Resolves #51581.

Not all calls to Array.Clear(Array, int, int) were changed. The three excluded categories are:

  • where the call site occurs within an assembly which targets downlevel API surface;
  • where the call site occurs within the Array unit test project itself; or
  • where the call site is in code which should remain untouched for compliance purposes.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented May 27, 2021

Tagging subscribers to this area: @tannergooding
See info in area-owners.md if you want to be subscribed.

Issue Details

Resolves #51581.

Not all calls to Array.Clear(Array, int, int) were changed. The three excluded categories are:

  • where the call site occurs within an assembly which targets downlevel API surface;
  • where the call site occurs within the Array unit test project itself; or
  • where the call site is in code which should remain untouched for compliance purposes.
Author: GrabYourPitchforks
Assignees: -
Labels:

area-System.Runtime

Milestone: 6.0.0

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@davidfowl
Copy link
Member

So no more array.AsSpan().Clear()

@GrabYourPitchforks
Copy link
Member Author

Test failures are known issue #53405.

@GrabYourPitchforks GrabYourPitchforks merged commit b759ac9 into dotnet:main May 28, 2021
@GrabYourPitchforks GrabYourPitchforks deleted the arr_clear branch May 28, 2021 04:08
@ghost ghost locked as resolved and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API proposal: Array.Clear(Array)
4 participants