Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OfficialBuildId property passing down to scripts #52927

Merged
merged 3 commits into from
May 18, 2021

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented May 18, 2021

Regressed with 4267d56

Validated the fix in #52897

cc @am11

@am11
Copy link
Member

am11 commented May 18, 2021

Thanks for checking it. Is it possible to trigger official legs (modulo the actual publishing part)?

@ViktorHofer
Copy link
Member Author

Thanks for checking it. Is it possible to trigger official legs (modulo the actual publishing part)?

Yes but in this case I would prefer to merge the change in fast to unblock CI and then react to potential official build issues. I will monitor the official builds that will contain the fix to see if something else needs to be done.

@ViktorHofer
Copy link
Member Author

The wasm leg passed the check, hence quick merging to unblock broken CI.

@ViktorHofer ViktorHofer merged commit 78372a0 into main May 18, 2021
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-2 branch May 18, 2021 18:00
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants