Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenSSL detection in PlatformDetection for Android #52798

Merged
merged 2 commits into from
May 19, 2021

Conversation

vcsjones
Copy link
Member

I noticed while working on the real ChaChaPoly1305 implementation for Android that the current tests are failing because it attempts to call in to the (non existing) OpenSSL shim in unit tests to check the IsSupported property.

This fixes that test bug for Android and non-macOS Apple platforms.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented May 15, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

I noticed while working on the real ChaChaPoly1305 implementation for Android that the current tests are failing because it attempts to call in to the (non existing) OpenSSL shim in unit tests to check the IsSupported property.

This fixes that test bug for Android and non-macOS Apple platforms.

Author: vcsjones
Assignees: -
Labels:

area-System.Security

Milestone: -

@steveisok steveisok self-requested a review May 15, 2021 02:41
@marek-safar marek-safar merged commit 593ac13 into dotnet:main May 19, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants