Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds extension method to create service scope that implements IAsyncDisposable. #51840

Merged
merged 8 commits into from
Apr 28, 2021
Merged

Adds extension method to create service scope that implements IAsyncDisposable. #51840

merged 8 commits into from
Apr 28, 2021

Commits on Apr 25, 2021

  1. Adds extension method to create service scope that implements IAsyncD… 

    …isposable.

- Introduces a new type AsyncServiceScope that implements IServiceScope and IAsyncDisposable. The type just wraps an existing IServiceScope instance, which it tries to cast it to an IAsyncDisposable when DisposeAsync is called.
- Adds netstandard2.1 target to avoid bringing in System.Threading.Tasks.Extensions and Microsoft.Bcl.AsyncInterfaces if not needed.
- Fixes dotnet#43970
    @bjorkstromm
    bjorkstromm committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    3111b1a View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2021

  1. Make AsyncServiceScope readonly 

    Co-authored-by: David Fowler <davidfowl@gmail.com>
    @bjorkstromm @davidfowl
    bjorkstromm and davidfowl authored Apr 26, 2021
    Configuration menu
    Copy the full SHA
    6c0ba3a View commit details
    Browse the repository at this point in the history

  2. Use null-coalescing for null checking and argument exception. 

    Co-authored-by: David Fowler <davidfowl@gmail.com>
    @bjorkstromm @davidfowl
    bjorkstromm and davidfowl authored Apr 26, 2021
    Configuration menu
    Copy the full SHA
    78a1726 View commit details
    Browse the repository at this point in the history

  3. Make AsyncServiceScope readonly in reference source.

    @bjorkstromm
    bjorkstromm committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    28dc589 View commit details
    Browse the repository at this point in the history

  4. Adds tests for AsyncServiceScope and CreateAsyncScope extension method.

    @bjorkstromm
    bjorkstromm committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    d42a96f View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2021

  1. Merge generated ref source.

    @bjorkstromm
    bjorkstromm committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    c70741f View commit details
    Browse the repository at this point in the history

  2. Document why 'default' is used instead of 'ValueTask.CompletedTask'

    @bjorkstromm
    bjorkstromm committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    ff0a56f View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary casts to IDisposable and IAsyncDisposable in tests.

    @bjorkstromm
    bjorkstromm committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    57edbbf View commit details
    Browse the repository at this point in the history