Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileStream rewrite: Caching the ValueTaskSource in AsyncWindowsFileStreamStrategy #51363

Merged
merged 15 commits into from
Apr 16, 2021
Merged

FileStream rewrite: Caching the ValueTaskSource in AsyncWindowsFileStreamStrategy #51363

merged 15 commits into from
Apr 16, 2021

Commits on Apr 16, 2021

  1. Caching the ValueTaskSource in AsyncWindowsFileStreamStrategy

    @carlossanlop
    carlossanlop committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    787fc8b View commit details
    Browse the repository at this point in the history

  2. Add debug assert to WriteByteSlow for _writePos == _bufferSize

    @carlossanlop
    carlossanlop committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    6de3827 View commit details
    Browse the repository at this point in the history

  3. Fix assertion failure

    @jozkee
    jozkee authored Apr 16, 2021
    Configuration menu
    Copy the full SHA
    f991eaa View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review

    @adamsitnik
    adamsitnik authored Apr 16, 2021
    Configuration menu
    Copy the full SHA
    efb426b View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review

    @adamsitnik
    adamsitnik authored Apr 16, 2021
    Configuration menu
    Copy the full SHA
    45f13e2 View commit details
    Browse the repository at this point in the history

  6. some pedantic polishing

    @adamsitnik
    adamsitnik committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    38b1431 View commit details
    Browse the repository at this point in the history

  7. fix the allocation bug: actually return the instance to the "pool"

    @adamsitnik
    adamsitnik committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    a9b314f View commit details
    Browse the repository at this point in the history

  8. don't Dipose the handle if it has default value

    @adamsitnik
    adamsitnik committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    a8011a6 View commit details
    Browse the repository at this point in the history

  9. reset _result and _source in the Configure method

    @adamsitnik
    adamsitnik committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    fe95056 View commit details
    Browse the repository at this point in the history

  10. delay the moment when the ValueTaskSource becomes ready to be reused … 

    …to the moment after _source.SetException|SetResult is called
    @adamsitnik
    adamsitnik committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    d1ebc47 View commit details
    Browse the repository at this point in the history

  11. apply Stephen suggestions

    @adamsitnik
    adamsitnik committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    4adf096 View commit details
    Browse the repository at this point in the history

  12. implement Stephen idea

    @adamsitnik
    adamsitnik committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    d101f45 View commit details
    Browse the repository at this point in the history

  13. use Reset in explicit way

    @adamsitnik
    adamsitnik committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    d4deefc View commit details
    Browse the repository at this point in the history

  14. remove outdated comment

    @adamsitnik
    adamsitnik committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    af10161 View commit details
    Browse the repository at this point in the history

  15. address code review feedback

    @adamsitnik
    adamsitnik committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    351b36b View commit details
    Browse the repository at this point in the history