-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: fix BasicBlock::isEmpty() #51340
Conversation
The detection of blocks with only PHI assignments was broken by dotnet#50806. Fix by using existing helper to find the first non-PHI assignment. Closes dotnet#51326.
@BruceForstall PTAL Will kick off jit stress for this PR shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
One asm diff via SPMI (RA making different choices), a few text diffs (likely block weight shifts). |
Arm32 tests passed, but CI failed to report success:
|
Jitstress ongoing, one failure so far, in |
Also seeing the burgers failure #51293. |
Failures are known |
The detection of blocks with only PHI assignments was broken by #50806.
Fix by using existing helper to find the first non-PHI assignment.
Closes #51326.