[debugger][mono][icordbg] Implement minimal version of dbgshim to start an application on desktop #50505

thaystg · 2021-03-31T19:24:39Z

Implemented more things on icordbg to try to run coreclr debugger tests
Implemented dbgshim to start the process on desktop with debugger enabled and load the correct mscordbi to connect to it.
Created a new folder for dlls, now we have dbgshim and mscordbi, as coreclr has.

Next steps:

Continue implementing icordebug to make the tests pass.
dbgshim be able to start app for android and ios.
Make it work for x86

dotnet-issue-labeler · 2021-03-31T19:24:45Z

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

lambdageek

Just a rough pass over the code.

The LoadLibrary hack is pretty ugly. I'd like to avoid it if we can.

Overall some good progress, though.

src/mono/dlls/dbgshim/dbgshim.cpp

src/mono/mono/mini/debugger-agent.c

src/mono/dlls/dbgshim/dbgshim.cpp

Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>

…time into thays_implement_dbgshim_mono

…shim_mono # By Aaron Robinson (10) and others # Via GitHub * upstream/main: (108 commits) [mbr] Add Apple sample (dotnet#50740) make EstablishProxyTunnelAsync throw on failure status code from proxy (dotnet#50763) Improve RGB Min Max evaluation performance by using 2 or 3 comparison… (dotnet#50622) [mono] More domain cleanups (dotnet#50479) Fix Crossgen2 of PlatformDefaultMemberFunction methods and calls. (dotnet#50754) Disable EventSource generator in design-time builds (dotnet#50741) Fix X509 test failures on Android (dotnet#50301) Do not confuse fgDispBasicBlocks in fgMorphBlocks (dotnet#50703) Enforce 64KB event payload size limit on EventPipe (dotnet#50600) Reorganize CoreCLR native build to reduce CMake reconfigures when the build system is untouched (dotnet#49906) [mbr] Turn on hot reload for iOS, tvOS and MacCatalyst (dotnet#50458) improve connection scavenge logic by doing zero-byte read (dotnet#50545) Resolve call mdtokens when making tier 1 inline observations (dotnet#50675) Annotate APIs in System.Private.Xml (dotnet#49682) Support compiling against OpenSSL 3 headers Change Configuration.Json to use a regular Dictionary. (dotnet#50611) Remove unused BigNumFromBinary P/Invoke (dotnet#50670) Make Ninja the default CMake generator on Windows for the repo (dotnet#49715) [AppleAppBuilder] Entitlements to run tests on catalyst using the JIT (dotnet#50637) [mono] Fix delegate invokes to dynamic methods in mixed mode. (dotnet#50547) ... # Conflicts: # src/mono/dlls/mscordbi/CMakeLists.txt

lambdageek

src/mono/mono/mini/debugger-protocol.c

Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>

filipnavara · 2021-04-13T15:36:56Z

🎉

hoyosjs · 2021-04-08T00:26:23Z

src/mono/dlls/dbgshim/CMakeLists.txt

+set(CMAKE_CXX_STANDARD 11)
+set(CMAKE_CXX_STANDARD_REQUIRED ON)
+
+set(CLR_DIR ${PROJECT_SOURCE_DIR}/../../coreclr)


It feels like this is one level short.

hoyosjs · 2021-04-08T00:27:00Z

src/mono/dlls/dbgshim/CMakeLists.txt

+  ${PROJECT_SOURCE_DIR}/../mscordbi
+  ${PROJECT_SOURCE_DIR}/../mscordbi/socket-dbi
+  ${PROJECT_SOURCE_DIR}/../../../coreclr/md/enc
+  ${PROJECT_SOURCE_DIR}/../../../coreclr/inc


Can you use the CLR_DIR property here?

hoyosjs · 2021-04-08T00:32:00Z

src/mono/dlls/mscordbi/cordb-assembly.cpp

+    {
+        if (!m_pAssemblyName) {
+            LOG((LF_CORDB, LL_INFO1000000, "CordbAssembly - GetName - IMPLEMENTED\n"));
+            MdbgProtBuffer localbuf;


I would not refer to Mdbg here. It was a test debugger and it's no longer something we distribute. If this is the old managed debugger tool

thaystg added 2 commits March 26, 2021 16:33

Running debugger tests on windows using mono runtime

1c86140

Coreclr Debugger Tests are running on windows

8a99335

thaystg added 2 commits March 31, 2021 16:28

Merge branch 'main' into thays_implement_dbgshim_mono

324d9ee

Removing wrong comments

b028f3f

lambdageek reviewed Mar 31, 2021

View reviewed changes

src/mono/dlls/dbgshim/dbgshim.cpp Outdated Show resolved Hide resolved

src/mono/mono/mini/debugger-agent.c Outdated Show resolved Hide resolved

src/mono/mono/mini/debugger-agent.c Outdated Show resolved Hide resolved

lambdageek reviewed Mar 31, 2021

View reviewed changes

src/mono/dlls/dbgshim/dbgshim.cpp Outdated Show resolved Hide resolved

thaystg and others added 3 commits March 31, 2021 17:41

Update src/mono/dlls/dbgshim/dbgshim.cpp

2138832

Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>

Changing what was suggested by @lambdageek

45e5589

Merge branch 'thays_implement_dbgshim_mono' of github.com:thaystg/run…

ff56ef1

…time into thays_implement_dbgshim_mono

runfoapp bot mentioned this pull request Apr 5, 2021

Builds legs getting abandoned due to agent notification issues #35223

Closed

thaystg added 3 commits April 6, 2021 10:08

Fix running tests on Mac

459e579

Fix windows compilation removing unused messages

003fe7b

thaystg marked this pull request as ready for review April 6, 2021 14:06

thaystg requested review from CoffeeFlux, marek-safar, SamMonoRT and vargaz as code owners April 6, 2021 14:06

thaystg added 5 commits April 6, 2021 11:15

Fix merge

2427a7e

Fix compilation on other platforms then amd64

78eaeca

Fix copy files when does not generate dbgshim and mscordbi

47f1933

Ignore when mscodbig and dbgshim is not found

96da364

Fix copy files when they don't exist

fb72dee

runfoapp bot mentioned this pull request Apr 8, 2021

Mono Windows Cross build failing #50753

Closed

lambdageek approved these changes Apr 13, 2021

View reviewed changes

src/mono/mono/mini/debugger-protocol.c Outdated Show resolved Hide resolved

Update src/mono/mono/mini/debugger-protocol.c

71f3c39

Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>

thaystg merged commit 82e8d0e into dotnet:main Apr 13, 2021

hoyosjs reviewed Apr 13, 2021

View reviewed changes

thaystg mentioned this pull request Apr 13, 2021

[mono][debugger ]Adding version to dbgshim and mscordbi #51194

Merged

ghost locked as resolved and limited conversation to collaborators May 13, 2021

karelz added this to the 6.0.0 milestone May 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[debugger][mono][icordbg] Implement minimal version of dbgshim to start an application on desktop #50505

[debugger][mono][icordbg] Implement minimal version of dbgshim to start an application on desktop #50505

thaystg commented Mar 31, 2021 •

edited

Loading

dotnet-issue-labeler bot commented Mar 31, 2021

lambdageek left a comment

lambdageek left a comment

filipnavara commented Apr 13, 2021

hoyosjs Apr 8, 2021

hoyosjs Apr 8, 2021

hoyosjs Apr 8, 2021 •

edited

Loading

[debugger][mono][icordbg] Implement minimal version of dbgshim to start an application on desktop #50505

[debugger][mono][icordbg] Implement minimal version of dbgshim to start an application on desktop #50505

Conversation

thaystg commented Mar 31, 2021 • edited Loading

dotnet-issue-labeler bot commented Mar 31, 2021

lambdageek left a comment

Choose a reason for hiding this comment

lambdageek left a comment

Choose a reason for hiding this comment

filipnavara commented Apr 13, 2021

hoyosjs Apr 8, 2021

Choose a reason for hiding this comment

hoyosjs Apr 8, 2021

Choose a reason for hiding this comment

hoyosjs Apr 8, 2021 • edited Loading

Choose a reason for hiding this comment

thaystg commented Mar 31, 2021 •

edited

Loading

hoyosjs Apr 8, 2021 •

edited

Loading