Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][windows][aot-cross] Skip ninja and cmake errors in aotcrossonly mode #50140

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

lewing
Copy link
Member

@lewing lewing commented Mar 24, 2021

No description provided.

@lewing lewing changed the title Skip ninja and cmake errors in aotcrossonly mode [wasm][windows][aot-cross] Skip ninja and cmake errors in aotcrossonly mode Mar 24, 2021
@lewing
Copy link
Member Author

lewing commented Mar 24, 2021

This appears to be breaking the rolling build.

@lewing
Copy link
Member Author

lewing commented Mar 24, 2021

Waiting while we do some checks to see what actually changed.

@lewing
Copy link
Member Author

lewing commented Mar 24, 2021

Does not look correct but the check is new and it worked previously so we're landing while we examine.

@lewing lewing closed this Mar 24, 2021
@lewing lewing reopened this Mar 24, 2021
Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try this!

@steveisok steveisok merged commit aab9aa6 into dotnet:main Mar 24, 2021
@lewing lewing deleted the wasm-aotcrossonly-cmake branch March 24, 2021 02:58
@ghost ghost locked as resolved and limited conversation to collaborators Apr 23, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants