[metadata_update] Fix bounds check error #49328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @CoffeeFlux Issue DetailsThe issue is that the STANDALONESIG bounds check was using a 0-based index, and But that made another call to the bounds check (in Fixes #49227
|
CoffeeFlux
approved these changes
Mar 8, 2021
This comment has been minimized.
This comment has been minimized.
The issue is that the STANDALONESIG bounds check was using a 0-based index, and mono_metadata_bounds_check_slow was compensating by adding 1. But that made another call to the bounds check fail: in mono_class_from_typeref_checked we passed a 1-based index. So in the case where a TypeRef was using the last AssemblyRef in a delta, the bound check would fail. Fixes dotnet#49227 Co-authored-by: Ryan Lucia <ryan@luciaonline.net>
lambdageek
force-pushed
the
mbr-fix-boundcheck-off-by-1
branch
from
540191a
to
dde1bb3
Compare
|
Hello @lambdageek! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that the STANDALONESIG bounds check was using a 0-based index, and
mono_metadata_bounds_check_slowwas compensating by adding 1.But that made another call to the bounds check fail: in
mono_class_from_typeref_checkedwe passed a 1-based index. So in the case where a TypeRef was using the last AssemblyRef in a delta, the bound check would fail.Fixes #49227