Fix ArgIterator::GetNextOffset for macOS arm64 #48632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ArgIterator::GetNextOffset method was not aligning offsets it returns for reference types and some others. That was causing coreclr test failures with GCStress mode 3. This change fixes it by properly aligning the returned offsets.
sandreenko
approved these changes
Feb 22, 2021
am11
reviewed
Feb 23, 2021
src/coreclr/vm/callingconvention.h
Outdated
| int alignment; | ||
| if (!isValueType) | ||
| { | ||
| _ASSERTE((cbArg & (cbArg - 1)) == 0); |
There was a problem hiding this comment.
Thank you for noticing this, fixed.
|
Hello @janvorli! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ArgIterator::GetNextOffset method was not aligning stack offsets it returns
for reference types and some others on macOS arm64. That was causing
coreclr test failures with GCStress mode 3.
This change fixes it by properly aligning the returned offsets.