flush CachedDirectoryStoreProvider on X509Store changes #48149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsThis is small change to skip cache refresh delay in cases when the directory is manipulated via X509Store Add or Remove function. It will flush all three cached stores. According to @bartonjs store manipulations are somewhat rare so I feel this would be ok. If we feel this is not ok, I can change it so we pass certificate store name and refresh only specific store.
|
bartonjs
approved these changes
Feb 11, 2021
geoffkizer
approved these changes
Feb 11, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is small change to skip cache refresh delay in cases when the directory is manipulated via X509Store Add or Remove function. It will flush all three cached stores. According to @bartonjs store manipulations are somewhat rare so I feel this would be ok. If we feel this is not ok, I can change it so we pass certificate store name and refresh only specific store.
fixes #48017
fixes #48091