Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add System.Linq Chunk extension method #47965

Merged
merged 9 commits into from
Feb 10, 2021
Merged

Add System.Linq Chunk extension method #47965

merged 9 commits into from
Feb 10, 2021

Conversation

inputfalken
Copy link
Contributor

Fix #27449

Some things I would especially like feedback on is:

  • The implementation for IQueryable<T> and its unit tests.
  • How to properly test that the optimization from System\Linq\Chunk.SpeedOpt.cs is actually used.
  • If the documentation is in the correct place.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Feb 6, 2021

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #27449

Some things I would especially like feedback on is:

  • The implementation for IQueryable<T> and its unit tests.
  • How to properly test that the optimization from System\Linq\Chunk.SpeedOpt.cs is actually used.
  • If the documentation is in the correct place.
Author: inputfalken
Assignees: -
Labels:

area-System.Linq, new-api-needs-documentation
Milestone: -

@eiriktsarpalis eiriktsarpalis mentioned this pull request Feb 9, 2021
Closed
6 tasks
eiriktsarpalis
eiriktsarpalis approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution!

@eiriktsarpalis
Copy link
Member

Build failure

NETCORE_ENGINEERING_TELEMETRY=Build) Validation Failed: System.Drawing.Common is harvesting assets from package version 5.0.0 which is not the latest for that package release.

seems unrelated to the change, merging away.

@eiriktsarpalis eiriktsarpalis merged commit 515bfaf into dotnet:master Feb 10, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub left review comments

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

Assignees
No one assigned
Labels
area-System.Linq new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IEnumerable should have a extension for creating fixed size chunks
3 participants
@inputfalken @eiriktsarpalis @stephentoub