Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PostEvictionCallbacks bug #46807

Merged
merged 4 commits into from
Jan 11, 2021
Merged

Fix PostEvictionCallbacks bug #46807

merged 4 commits into from
Jan 11, 2021

Commits on Jan 11, 2021

  1. add a failing test

    @adamsitnik
    adamsitnik committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    c62f5b9 View commit details
    Browse the repository at this point in the history

  2. fix the actual bug (this was not a CacheEntry but a CacheEntryTokens … 

    …instance here)
    @adamsitnik
    adamsitnik committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    2e8cdcf View commit details
    Browse the repository at this point in the history

  3. address code review feedback

    @adamsitnik
    adamsitnik committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    32f43c5 View commit details
    Browse the repository at this point in the history

  4. address code review feedback: 

    - remove the dependency to TaskTimeoutExtensions
- don't wait 1s, call Cancel in explicit way
    @adamsitnik
    adamsitnik committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    76d319c View commit details
    Browse the repository at this point in the history