issue-46477 Fix issue about checking last char in datetime string. #46614
Conversation
|
|
||
| Assert.Throws<FormatException>(() => DateTime.Parse("2020-5-7T09:37:00.0000000-07:00c")); | ||
| Assert.Throws<FormatException>(() => DateTime.Parse("2020-5-7T09:37:00.0000000-07:00c", new MyFormatter())); | ||
| Assert.Throws<FormatException>(() => DateTime.Parse("2020-5-7T09:37:00.0000000-07:00c", new MyFormatter(), DateTimeStyles.NoCurrentDateDefault)); |
There was a problem hiding this comment.
these should continue to work (per the strange treatment of # and \0), so you might want to add a test to prove they were not broken by your change:
2020-5-7T09:37:00.0000000+00:00\0
#2020-5-7T09:37:00.0000000+00:00#
#2020-5-7T09:37:00.0000000+00:00#\0
I only see tests for these without the timezone part.
These should still fail and aren't tested
2020-5-7T09:37:00.0000000+00:00#
2020-5-7T09:37:00.0000000+00:00#\0
I think your fix is good though - thanks.
There was a problem hiding this comment.
I second @danmosemsft for adding more test cases for valid formats. Also, please ensure adding cases when there is nothing at the end too. something like 2020-5-7T09:37:00.0000000-07:00
There was a problem hiding this comment.
@danmosemsft @tarekgh Fixed, please review, thanks.
|
@lateapexearlyspeed did you have a chance to address the feedback on this PR? |
|
@tarekgh Sorry I am little busy these days, will fix those comment these days. |
|
@lateapexearlyspeed no problem and thanks again for helping with this one. |
|
The failure in this PR is unrelated and tracked by the linked issue #32805 |
ghost
locked as resolved and limited conversation to collaborators
Fix #46477