Clean up managed dependencies for Mono's domain/loader context #46323

marek-safar · 2020-12-22T13:45:05Z

No description provided.

lambdageek · 2020-12-22T14:07:58Z

src/mono/mono/metadata/object-internals.h

-	MonoObject *unload_lock;
-	MonoEvent *resolving_unmaned_dll;
-	MonoEvent *resolving;
-	MonoEvent *unloading;
-	MonoString *name;
 	MonoAssemblyLoadContext *native_assembly_load_context;
-	gint64 id;
-	gint32 internal_state;
-	MonoBoolean is_collectible;


@CoffeeFlux are any of these fields going to be necessary for future collectible ALC work?

lambdageek

Good idea

all the places where we use MONO_STATIC_POINTER_INIT need an additional inited flag now, so that we don't look for the method on every invocation when the pointer is allowed to be NULL
There are a few more uses of mono_class_get_appdomain_class etc that are visible that will break. mono_class_get_appdomain_class is generated by GENERATE_GET_CLASS_WITH_CACHE which will assert if the class isn't found. There's a GENERATE_TRY_GET_CLASS_WITH_CACHE_DECL that makes a getter that can return null, but in this case I think it's just easier to put all the uses under an ifdef.

src/mono/mono/metadata/appdomain.c

src/mono/mono/metadata/assembly-load-context.c

src/mono/mono/metadata/icall.c

src/mono/mono/metadata/native-library.c

src/mono/mono/metadata/object.c

src/mono/netcore/System.Private.CoreLib/src/System/Runtime/Loader/AssemblyLoadContext.Mono.cs

src/mono/mono/metadata/class-internals.h

Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>

lambdageek · 2020-12-23T14:48:19Z

src/mono/mono/mini/mini-runtime.c

@@ -358,6 +358,7 @@ mono_print_method_from_ip (void *ip)
 */
 gboolean mono_method_same_domain (MonoJitInfo *caller, MonoJitInfo *callee)
 {
+#ifndef ENABLE_NETCORE


(Same problem in #46346 ) this #ifndef should be lower, before the line cmethod = jinfo_get_method (caller); - we still want to return FALSE for trampolines and other edge cases

Fix like this: ~~fed6bcc~~ f31ccde

Yeah, will wait for you to land that first and rebase this PR

This reverts commit 94e855e.

Follow up change missing in dotnet#46323 Fixes dotnet#46908

Follow up change missing in dotnet/runtime#46323 Fixes dotnet/runtime#46908

…6917) Follow up change missing in #46323 Fixes #46908

…0743) Follow up change missing in dotnet/runtime#46323 Fixes dotnet/runtime#46908 Co-authored-by: marek-safar <marek-safar@users.noreply.github.com>

marek-safar requested review from akoeplinger, CoffeeFlux, EgorBo, lambdageek, SamMonoRT, steveisok, thaystg and vargaz as code owners December 22, 2020 13:45

Dotnet-GitSync-Bot added the area-CoreLib-mono label Dec 22, 2020

monojenkins mentioned this pull request Dec 22, 2020

Clean up managed dependencies for Mono's domain/loader context mono/mono#20691

Merged

lambdageek reviewed Dec 22, 2020

View reviewed changes

vargaz approved these changes Dec 22, 2020

View reviewed changes

lambdageek requested changes Dec 22, 2020

View reviewed changes

Clean up managed dependencies for Mono's domain/loader context

caa49b2

marek-safar force-pushed the desc branch from e1ec07d to caa49b2 Compare December 22, 2020 17:02

marek-safar and others added 9 commits December 22, 2020 18:05

Update src/mono/mono/metadata/appdomain.c

93fe5a0

Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>

Update src/mono/mono/metadata/appdomain.c

b12463f

Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>

Update src/mono/mono/metadata/assembly-load-context.c

cc1d5d2

Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>

Update src/mono/mono/metadata/assembly-load-context.c

989dc24

Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>

Update src/mono/mono/metadata/icall.c

30865f4

Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>

Update src/mono/mono/metadata/icall.c

4033382

Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>

Update src/mono/mono/metadata/native-library.c

3233637

Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>

Update src/mono/mono/metadata/object.c

6fb33b8

Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>

Update src/mono/mono/metadata/object.c

7a252c4

Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>

This was referenced Dec 22, 2020

Mono System.Text.Json.Tests on Windows timing out #42677

Open

System.Threading.Tasks.Tests timed out on net5.0-Linux-Debug-arm64-Mono_release #42024

Closed

Mono SIGABRT in System.Drawing.Common affecting some test runs #37838

Closed

fixup one mono_error_cleanup

c965abe

lambdageek approved these changes Dec 22, 2020

View reviewed changes

runfoapp bot mentioned this pull request Dec 22, 2020

SSL error when downloading the dotnet install script #46309

Closed

lambdageek reviewed Dec 23, 2020

View reviewed changes

marek-safar added 3 commits December 23, 2020 23:46

Merge remote-tracking branch 'upstream/master' into desc

d691de5

ifdef merge conflict

2d301e0

Merge branch 'desc' of github.com:marek-safar/runtime into desc

f58fd0f

runfoapp bot mentioned this pull request Dec 24, 2020

Inability to unzip assets during build on Unix x64 #32805

Closed

marek-safar force-pushed the desc branch from 21c6907 to c900ac5 Compare December 24, 2020 23:12

get debug messages

94e855e

marek-safar force-pushed the desc branch 2 times, most recently from 07b3f44 to 044ccf5 Compare December 26, 2020 13:29

marek-safar added 2 commits December 26, 2020 19:25

Don't assume presence of OnAssemblyLoad method

a0ff4b8

Revert "get debug messages"

6b129ad

This reverts commit 94e855e.

marek-safar force-pushed the desc branch from 044ccf5 to 6b129ad Compare December 26, 2020 18:26

marek-safar merged commit 5078dd6 into dotnet:master Dec 27, 2020

marek-safar deleted the desc branch December 27, 2020 08:11

This was referenced Dec 28, 2020

Testing out the new system jaredpar/runfo#71

Open

Errors installing the SDK during builds #34015

Closed

rolfbjarne mentioned this pull request Jan 13, 2021

iOS: System.Runtime.Loader.AssemblyLoadContext.MonoResolveUnmanagedDllUsingEvent is linked away when still needed #46908

Closed

marek-safar mentioned this pull request Jan 13, 2021

Don't assume presence of MonoResolveUnmanagedDllUsingEvent method #46917

Merged

monojenkins mentioned this pull request Jan 13, 2021

Don't assume presence of MonoResolveUnmanagedDllUsingEvent method mono/mono#20743

Merged

marek-safar added a commit to marek-safar/runtime that referenced this pull request Jan 13, 2021

Don't assume presence of MonoResolveUnmanagedDllUsingEvent method

e85be98

Follow up change missing in dotnet#46323 Fixes dotnet#46908

monojenkins pushed a commit to monojenkins/mono that referenced this pull request Jan 13, 2021

Don't assume presence of MonoResolveUnmanagedDllUsingEvent method

be3d067

Follow up change missing in dotnet/runtime#46323 Fixes dotnet/runtime#46908

marek-safar added a commit that referenced this pull request Jan 13, 2021

Don't assume presence of MonoResolveUnmanagedDllUsingEvent method (#4…

ed7d2fb

…6917) Follow up change missing in #46323 Fixes #46908

ghost locked as resolved and limited conversation to collaborators Jan 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up managed dependencies for Mono's domain/loader context #46323

Clean up managed dependencies for Mono's domain/loader context #46323

marek-safar commented Dec 22, 2020

lambdageek Dec 22, 2020

lambdageek left a comment

lambdageek Dec 23, 2020

lambdageek Dec 23, 2020 •

edited

Loading

marek-safar Dec 23, 2020

Clean up managed dependencies for Mono's domain/loader context #46323

Clean up managed dependencies for Mono's domain/loader context #46323

Conversation

marek-safar commented Dec 22, 2020

lambdageek Dec 22, 2020

Choose a reason for hiding this comment

lambdageek left a comment

Choose a reason for hiding this comment

lambdageek Dec 23, 2020

Choose a reason for hiding this comment

lambdageek Dec 23, 2020 • edited Loading

Choose a reason for hiding this comment

marek-safar Dec 23, 2020

Choose a reason for hiding this comment

lambdageek Dec 23, 2020 •

edited

Loading