Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce CacheEntry size #45962

Merged
merged 19 commits into from
Jan 7, 2021
Merged

Reduce CacheEntry size #45962

merged 19 commits into from
Jan 7, 2021

Commits on Dec 10, 2020

  1. reduce the size of CacheEntry instance by 2xsizeof(int)

    @adamsitnik
    adamsitnik committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    227c96d View commit details
    Browse the repository at this point in the history

  2. remove _lock field and use "this" for locking instead

    @adamsitnik
    adamsitnik committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    5c8b862 View commit details
    Browse the repository at this point in the history

  3. move _expirationTokenRegistrations, _postEvictionCallbacks and _expir… 

    …ationTokens to separate type to reduce the typicall cache entry size
    @adamsitnik
    adamsitnik committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    4b529fb View commit details
    Browse the repository at this point in the history

  4. move private types into separate files

    @adamsitnik
    adamsitnik committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    c04da17 View commit details
    Browse the repository at this point in the history

  5. rename the types + add comments

    @adamsitnik
    adamsitnik committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    217ab43 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. inline private properties that are used just twice in total

    @adamsitnik
    adamsitnik committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    c6597db View commit details
    Browse the repository at this point in the history

  2. force inline some methods based on profiling data

    @adamsitnik
    adamsitnik committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    c519666 View commit details
    Browse the repository at this point in the history

  3. rename files

    @adamsitnik
    adamsitnik committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    4a5715a View commit details
    Browse the repository at this point in the history

  4. apply code review suggestion

    @adamsitnik
    adamsitnik committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    f170e8d View commit details
    Browse the repository at this point in the history

  5. apply code review suggestion: don't use Enum.HasFlag 

    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    @adamsitnik @jkotas
    adamsitnik and jkotas authored Dec 11, 2020
    Configuration menu
    Copy the full SHA
    01a2686 View commit details
    Browse the repository at this point in the history

  6. apply code review suggestion: don't use Enum.HasFlag

    @adamsitnik
    adamsitnik committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    0c07731 View commit details
    Browse the repository at this point in the history

  7. apply code review suggestion: remove redundant Interlocked.CompareExc… 

    …hange
    @adamsitnik
    adamsitnik committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    46ae2ea View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2020

  1. address code review feedback: encapsulate the fields of CacheEntryTokens

    @adamsitnik
    adamsitnik committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    c3e75ea View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
    @adamsitnik @eerhardt @stephentoub
    3 people authored Jan 5, 2021
    Configuration menu
    Copy the full SHA
    f582eb6 View commit details
    Browse the repository at this point in the history

  2. there is no need for explicit memory layout anymore

    @adamsitnik
    adamsitnik committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    6a39239 View commit details
    Browse the repository at this point in the history

  3. there is no need for using IList abstraction (the field was changed f… 

    …rom List to IList)
    @adamsitnik
    adamsitnik committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    58d6a0e View commit details
    Browse the repository at this point in the history

  4. restore call to parameterless ctor to ensure that all struct fields a… 

    …re initialized
    @adamsitnik
    adamsitnik committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    a1fcbd1 View commit details
    Browse the repository at this point in the history

  5. CopyTokens => PropagateTokens for naming consistency with PropagateOp… 

    …tions
    @adamsitnik
    adamsitnik committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    356e02f View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
    @adamsitnik @eerhardt
    adamsitnik and eerhardt authored Jan 7, 2021
    Configuration menu
    Copy the full SHA
    9b189eb View commit details
    Browse the repository at this point in the history