Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Use timezone abbreviations as fallback if full names don't exist #45385

Merged
merged 10 commits into from
Mar 5, 2021
Merged

[wasm] Use timezone abbreviations as fallback if full names don't exist #45385

merged 10 commits into from
Mar 5, 2021

Commits on Nov 30, 2020

  1. use unix ver of GetDisplayName instead of invariant display name

    @tqiu8
    tqiu8 committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    eac0385 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2021

  1. Merge branch 'master' into tz-displayname-fix

    @tqiu8
    tqiu8 committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    a040a7e View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2021

  1. Add tests for Daylight Names

    @tqiu8
    tqiu8 committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    429689e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into tz-displayname-fix

    @tqiu8
    tqiu8 committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    93c0f35 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2021

  1. Use tz abbreviations as fallback for browser cases, added test cases,… 

    … fixed regex
    @tqiu8
    tqiu8 committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    9b4230a View commit details
    Browse the repository at this point in the history

  2. Move abbrev fields to TimeZoneInfo.Unix.cs

    @tqiu8
    tqiu8 committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    33ff298 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2021

  1. [wasm] If standard, or daylight names are not available, then fallback 

    .. to abbreviations.

[This code](https://github.com/dotnet/runtime/blob/master/src/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.GetDisplayName.cs#L29-L40) seems to return `true` result, even though `timeZoneDisplayName` is null/empty. So, in such a case don't set the out var
and let the abbrev get used as the fallback (like it already says in the
comment).
    @radical
    radical committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    1805c6d View commit details
    Browse the repository at this point in the history

  2. Merge pull request #4 from radical/rf-tz-displayname-fix 

    [wasm] If standard, or daylight names are not available, then fallback
    @tqiu8
    tqiu8 authored Jan 13, 2021
    Configuration menu
    Copy the full SHA
    c0d5599 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. add additional platform tests

    @tqiu8
    tqiu8 committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    8478bee View commit details
    Browse the repository at this point in the history

  2. edit displayname test

    @tqiu8
    tqiu8 committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    3524f6a View commit details
    Browse the repository at this point in the history