Fix -output_mch_path argument to superpmi.py
#44693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert the given path argument to an absolute path. Without this, the `collect` command changes the current directory before doing its work, so the file doesn't end up where you expeect it to. Also, print the given argument in any error message.
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
|
@kunalspathak PTAL |
kunalspathak
approved these changes
Nov 15, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the given path argument to an absolute path. Without this,
the
collectcommand changes the current directory before doing itswork, so the file doesn't end up where you expeect it to.
Also, print the given argument in any error message.