Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new net6.0 TargetFramework #42709

Merged
merged 6 commits into from
Oct 7, 2020
Merged

Add a new net6.0 TargetFramework #42709

merged 6 commits into from
Oct 7, 2020

Conversation

Anipik
Copy link
Contributor

@Anipik Anipik commented Sep 24, 2020

  • adding a new target framework net6.0
  • making coreclr tool target net5.0
  • make packages containing net5.0 exclude netcoreappcurrent

src/libraries/shims/ApiCompat.proj Show resolved Hide resolved
eng/packaging.targets Outdated Show resolved Hide resolved
Directory.Build.targets Outdated Show resolved Hide resolved
src/libraries/pkg/test/packageTest.targets Outdated Show resolved Hide resolved
src/coreclr/tests/scripts/run-corefx-tests.py Outdated Show resolved Hide resolved
eng/common/performance/performance-setup.ps1 Outdated Show resolved Hide resolved
eng/common/performance/performance-setup.sh Outdated Show resolved Hide resolved
Directory.Build.targets Show resolved Hide resolved
@ViktorHofer
Copy link
Member

Can you please verify if vstest still works? I believe the xunit.visualstudio package and vstest were hardcoding on checking for "net5.0" of "netcoreapp". cc @nohwnd

@nohwnd
Copy link
Member

nohwnd commented Sep 29, 2020

@ViktorHofer yes, it should work. The change that caused that problem was rolled back somewhere between Preview8 and 5.0.100-rc.1.20451.10.

@Anipik
Copy link
Contributor Author

Anipik commented Oct 2, 2020

@marek-safar @akoeplinger can you help with the browser errors here ? i m not aware how everything is put together.
From the error it seems an bin log it seems like that $(CORE_ROOT) property is not getting set.

@Anipik
Copy link
Contributor Author

Anipik commented Oct 5, 2020

@ViktorHofer @ericstj @safern this one is complete, can you please take a look ?

Comment on lines +5 to +6
<NuGetTargetMoniker>$(NetCoreAppCurrentToolTargetFrameworkMoniker)</NuGetTargetMoniker>
<NuGetTargetMonikerShort>$(NetCoreAppToolCurrent)</NuGetTargetMonikerShort>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these properties needed? Don't we want to set a tfm here? cc @ericstj @trylek

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍👍

Directory.Build.targets Outdated Show resolved Hide resolved
@ViktorHofer
Copy link
Member

@Anipik before merging, please validate if building and testing inside Visual Studio still works. Also please validate that dotnet test on the CLI still works (we don't protect that yet in CI).

@Anipik
Copy link
Contributor Author

Anipik commented Oct 6, 2020

@Anipik before merging, please validate if building and testing inside Visual Studio still works. Also please validate that dotnet test on the CLI still works (we don't protect that yet in CI).

  1. Package sizes are same before and after the change
  2. Dotnet test works from the CLI
  3. Able to build projects form VS (we still get duplicate tfm error while restoring from the VS)
  4. We are able to run tests using the VS

@Anipik
Copy link
Contributor Author

Anipik commented Oct 7, 2020

Merging the change as failure is known and we have a tracking issue.

@ViktorHofer
Copy link
Member

ViktorHofer commented Oct 7, 2020

Note that this is a breaking change which ideally would go trough a monthly rollout. Please send out a mail to the team explaining why this was merged now and what the breaking change is about.

@Anipik Anipik merged commit 2db7179 into dotnet:master Oct 7, 2020
@Anipik Anipik deleted the net63 branch October 7, 2020 22:37
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants