Ongoing cmake build work. #42182
Merged
Ongoing cmake build work. #42182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vargaz
commented
Sep 13, 2020
vargaz
commented
- Fix indentation.
- Add linux support.
- Add tvos support.
- Use clang only options only with clang.
- Add check for iconv.
vargaz
requested review from
CoffeeFlux,
lambdageek,
marek-safar and
SamMonoRT
as code owners
* Fix indentation. * Add linux support. * Add tvos support. * Use clang only options only with clang. * Add check for iconv.
CoffeeFlux
approved these changes
Sep 17, 2020
src/mono/CMakeLists.txt
Outdated
|
|
||
| check_c_compiler_flag("-Werror=incompatible-pointer-types" WERROR_INCOMPATIBLE_POINTER_TYPES) | ||
| if(WERROR_INCOMPATIBLE_POINTER_TYPES) | ||
| set(WERROR "${WERROR} -Werror=incompatible-pointer-types") |
There was a problem hiding this comment.
This is a tab, which I assume is a mistake? Also, why are we using spaces here—is this a dotnet/runtime CMake standard?
There was a problem hiding this comment.
Not sure whenever we should use spaces or tabs.
src/mono/CMakeLists.txt
Outdated
| set(HAVE_SYSTEM 0) | ||
| set(MONO_DL_NEED_USCORE 1) | ||
| if(CMAKE_SYSTEM_NAME STREQUAL "tvOS") | ||
| set(HOST_TVOS 1) |
There was a problem hiding this comment.
Tab again. Maybe specify the cmake files in the editorconfig as well, as a followup to Aleksey's PR?
| "#include <sched.h>\n" | ||
| "void main () { CPU_COUNT((void *) 0); }\n" | ||
| ) | ||
| try_compile(GLIBC_HAS_CPU_COUNT ${CMAKE_BINARY_DIR}/CMakeTmp SOURCES "${CMAKE_BINARY_DIR}{$CMAKE_FILES_DIRECTORY}/CMakeTmp/test.c" |
There was a problem hiding this comment.
CMake path handling is so bad :(
I think cmake_path got merged upstream earlier this month? But it's still clunky and we probably can't depend on a bleeding edge version, alas.
CoffeeFlux
reviewed
Sep 17, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.